Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker service is still running for contianed #11515

Closed
medyagh opened this issue May 26, 2021 · 1 comment · Fixed by #11516
Closed

docker service is still running for contianed #11515

medyagh opened this issue May 26, 2021 · 1 comment · Fixed by #11516
Labels
co/runtime/containerd kind/bug Categorizes issue or PR as related to a bug.

Comments

@medyagh
Copy link
Member

medyagh commented May 26, 2021

$ mk start --driver=docker --container-runtime=containerd
$ mk ssh
docker@minikube:~$ sudo systemctl status docker
● docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
   Active: active (running)
@medyagh
Copy link
Member Author

medyagh commented May 26, 2021

I thnk the source of the problem is this line, if I comment it out it disables

		// runtime is already disabled, nothing to do.
		// if !r.Active() {
		// 	fmt.Println("no need to disable this its already not active", r.Name())
		// 	continue
		// }

@medyagh medyagh added co/runtime/containerd kind/bug Categorizes issue or PR as related to a bug. labels May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/containerd kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant