minikube image load not updating image if loading image with existing name:tag

[spowelljr]

% minikube start

% docker build -t benchmark-image -f Dockerfile.large .

% docker images --all
REPOSITORY                                TAG        IMAGE ID       CREATED          SIZE
benchmark-image                           latest     e066761bca06   4 minutes ago    937MB

% minikube image load benchmark-image:latest

% eval $(./out/minikube docker-env) && docker image ls
REPOSITORY                                TAG        IMAGE ID       CREATED          SIZE
benchmark-image                           latest     e066761bca06   4 minutes ago    937MB

% docker build -t benchmark-image -f Dockerfile.small .

% docker images --all
REPOSITORY                                TAG        IMAGE ID       CREATED          SIZE
benchmark-image                           latest     60c0c9285193   2 minutes ago    721MB

% minikube image load benchmark-image:latest

% eval $(./out/minikube docker-env) && docker image ls
REPOSITORY                                TAG        IMAGE ID       CREATED          SIZE
benchmark-image                           latest     e066761bca06   4 minutes ago    937MB

As you can see above, pushing an image with the same name:tag does not update within minikube.

[afbjorklund]

This is the same behaviour as the cache, we don't reload images that have the same name/tag.

#10060

[afbjorklund]

There are bunch of hard-coded checks for "preloaded" images and for scp of existing files

        // Skip loading images if images already exist
        if cr.ImagesPreloaded(images) {
                klog.Infof("Images are preloaded, skipping loading")
                return nil
        }

        // For tiny files, it's cheaper to overwrite than check
        if f.GetLength() > 4096 {
                exists, err := fileExists(k, f, dst)
                if err != nil {
                        klog.Infof("existence error for %s: %v", dst, err)
                }
                if exists {
                        klog.Infof("copy: skipping %s (exists)", dst)
                        return nil
                }
        }

These could possibly be regarded as features, but should be optional (like imagePullPolicy)

[spowelljr]

In-progress