Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm stderr is occasionally truncated #10570

Closed
tstromberg opened this issue Feb 22, 2021 · 3 comments · Fixed by #10694
Closed

kubeadm stderr is occasionally truncated #10570

tstromberg opened this issue Feb 22, 2021 · 3 comments · Fixed by #10694
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@tstromberg
Copy link
Contributor

tstromberg commented Feb 22, 2021

As noted in #10508 - I suspect there may be a recent regression in our ability to preserve kubeadm output, but it may also be a much older issue.

It might be worth checking against minikube v1.15 for instance, to see if the behavior changed, with an identical --kubernetes-version selected.

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 22, 2021
@spowelljr spowelljr added this to the v1.18.0 milestone Feb 22, 2021
@spowelljr
Copy link
Member

In-progress

@spowelljr
Copy link
Member

spowelljr commented Feb 23, 2021

I removed session.Close() from cmd.Wait as cmd.Run doesn't call it, now the stderr logs are there sometimes and sometimes not, there seems to be a race condition going on.

@tstromberg
Copy link
Contributor Author

Nice work on solving this tricky race condition within an exceptionally tricky section of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants