Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement operation auditing for minkube (--user) flag #10041

Closed
medyagh opened this issue Dec 24, 2020 · 2 comments
Closed

implement operation auditing for minkube (--user) flag #10041

medyagh opened this issue Dec 24, 2020 · 2 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Dec 24, 2020

there should be a way to know what user did what operition on a minikube cluster

(to be used by multiple tools that use minikube at the same time
skaffold, cloud code, cloud run, cloud shel ....)

----------------------------------------
command, option, user , start_time , end_time
----------------------------------------
start, --driver=docker , driver, cloud-code, 223232,2 23232
start, --driver=hyperkit , driver, code-shell, 223232,2 23232
stop, steven, 223232,2 23232

if no user was provided, it should default to the OS user name

@spowelljr
Copy link
Member

/assign

@medyagh medyagh added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 24, 2020
@priyawadhwa
Copy link

priyawadhwa commented Jan 8, 2021

Ideas for this (no need to actually do them if you think of something better)

Commands we will track: start, stop, pause, unpause, delete
Command we won't track because they may clutter the log: status, version

Options for deleting the audit file:

  1. consistently append to a single file and assume that it will be deleted whenever a user runs --purge
  2. put a TTL on the audit file (if it hasn't been modified in a week, delete it and start a new one)

Whenever we append to the file, we can also log what we are appending to STDERR which will satisfy #9520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants