From c283c807a989c74ae206768bc53cf2f0476c9c6f Mon Sep 17 00:00:00 2001 From: Sharif Elgamal Date: Fri, 25 Jun 2021 11:36:18 -0700 Subject: [PATCH] better functional and test name --- test/integration/functional_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go index 8049a18f96f5..5d0d5948b811 100644 --- a/test/integration/functional_test.go +++ b/test/integration/functional_test.go @@ -105,8 +105,8 @@ func TestFunctional(t *testing.T) { t.Fatalf("Unable to run more tests (deadline exceeded)") } if tc.name == "StartWithProxy" && runCorpProxy { - tc.name = "StartWithCorpProxy" - tc.validator = validateStartWithCorpProxy + tc.name = "StartWithCustomCerts" + tc.validator = validateStartWithCustomCerts } t.Run(tc.name, func(t *testing.T) { tc.validator(ctx, t, profile) @@ -543,9 +543,9 @@ func validateStartWithProxy(ctx context.Context, t *testing.T, profile string) { startMinikubeWithProxy(ctx, t, profile, "HTTP_PROXY", srv.Addr) } -// validateStartWithCorpProxy makes sure minikube start respects the HTTPS_PROXY environment variable +// validateStartWithCustomCerts makes sure minikube start respects the HTTPS_PROXY environment variable // only runs on Github Actions for amd64 linux -func validateStartWithCorpProxy(ctx context.Context, t *testing.T, profile string) { +func validateStartWithCustomCerts(ctx context.Context, t *testing.T, profile string) { defer PostMortemLogs(t, profile) err := startCorpProxy(ctx, t) if err != nil {