From 66ecadce47fdfa67e297d53b62475b047fc3c203 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Thu, 18 Feb 2021 18:39:35 -0700 Subject: [PATCH] added missing err check to scanner and new section logs integration test --- pkg/minikube/logs/logs.go | 3 +++ test/integration/functional_test.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/logs/logs.go b/pkg/minikube/logs/logs.go index 54af4abc400f..fbbc5b23c64b 100644 --- a/pkg/minikube/logs/logs.go +++ b/pkg/minikube/logs/logs.go @@ -214,6 +214,9 @@ func outputLastStart() error { for s.Scan() { out.Step(style.Empty, s.Text()) } + if err := s.Err(); err != nil { + return fmt.Errorf("failed to read file %s: %v", fp, err) + } return nil } diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go index c63c6f94a8a5..520d65533353 100644 --- a/test/integration/functional_test.go +++ b/test/integration/functional_test.go @@ -768,7 +768,7 @@ func validateLogsCmd(ctx context.Context, t *testing.T, profile string) { if err != nil { t.Errorf("%s failed: %v", rr.Command(), err) } - expectedWords := []string{"apiserver", "Linux", "kubelet"} + expectedWords := []string{"apiserver", "Linux", "kubelet", "Last Start"} switch ContainerRuntime() { case "docker": expectedWords = append(expectedWords, "Docker")