-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take the context as the first argument of Schedule #82119
Take the context as the first argument of Schedule #82119
Conversation
/sig scheduling |
bb0f07d
to
df579d0
Compare
df579d0
to
008f4e2
Compare
Technically yes, although this is not the real context.Context. Prefer to incorporate this changes in #82072 where introduced the real context.Context. cc/ @draveness |
Agree with that. It looks better. |
/cc @ahg-g |
I believe this was superseded by #82072 :) |
Per offline discussion with @ahg-g, it seems we have another PR slipped in and made "PluginContext" as the first parameter. To make the API parameters consistent ( |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, wgliang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
According to #81876 (comment)
FYI:https://golang.org/pkg/context/
The Context should be the first parameter
So we will take the context as the first argument of Schedule()
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: