Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubeadm config refactor JoinControlPlane #70870

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Kubeadm config refactor JoinControlPlane #70870

merged 2 commits into from
Nov 12, 2018

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Nov 9, 2018 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
As agree in latest review of kubeadm v1beta1 api, we should introduce JoinControlPlane struct and make it pointer/nullable because it corresponds to an alpha feature

rif: kubernetes/kubeadm#911

Special notes for your reviewer:
/sig cluster-lifecycle
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/assign @timothysc
/assign @luxas
/cc @rosti

Does this PR introduce a user-facing change?:

Kubeadm:  attributes for join --control-plane workflow are now grouped into a dedicated JoinControlPlane struct

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/kubeadm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2018
timothysc
timothysc approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

could nit, but we need to keep going.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timothysc timothysc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 9, 2018
@fabriziopandini
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-kops-aws

@rosti
Copy link
Contributor

rosti commented Nov 9, 2018

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2018
@fabriziopandini
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
timothysc
timothysc reviewed Nov 12, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/test pull-kubernetes-e2e-kops-aws

@timothysc timothysc added this to the v1.13 milestone Nov 12, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 99811e2 into kubernetes:master Nov 12, 2018
luxas
luxas reviewed Nov 12, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactive LGTM. Thanks @fabriziopandini 🎉!

@fabriziopandini fabriziopandini deleted the kubeadm-config-JoinControlPlane branch December 15, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas left review comments

@timothysc timothysc timothysc approved these changes

@rosti rosti Awaiting requested review from rosti

Assignees

@timothysc timothysc

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
6 participants
@fabriziopandini @k8s-ci-robot @rosti @fejta-bot @timothysc @luxas