Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in node tree when all nodes in a zone are removed #69758

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Fix a bug in node tree when all nodes in a zone are removed #69758

merged 1 commit into from
Oct 14, 2018

Conversation

bsalamat
Copy link
Member

What this PR does / why we need it:
Fixes a bug in node-tree of the scheduler when all nodes in a zone are removed while "next" is called in certain order.
This issue happens rarely, but if it happens the scheduler can no longer iterate over nodes and goes to an infinite loop trying to find the next node. The only solution is to restart the scheduler.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69597

Special notes for your reviewer:

Release note:

Fix a bug in the scheduler that could cause the scheduler to go to an infinite loop when all nodes in a zone are removed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2018
@bsalamat bsalamat added kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 13, 2018
@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2018
@bsalamat bsalamat requested review from k82cn and removed request for davidopp October 13, 2018 04:50
@bsalamat bsalamat mentioned this pull request Oct 13, 2018
Merged
@AishSundar AishSundar mentioned this pull request Oct 13, 2018
Closed
@AishSundar
Copy link
Contributor

@feiskyer FYI that this needs to be CPed into 1.12

@bsalamat
Copy link
Member Author

/retest

@bsalamat
Copy link
Member Author

@AishSundar @feiskyer #69759 is the cherrypick

@k82cn
Copy link
Member

k82cn commented Oct 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@ravisantoshgudimetla
Copy link
Contributor

/retest

ravisantoshgudimetla
ravisantoshgudimetla approved these changes Oct 14, 2018
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bsalamat.

/lgtm

@ravisantoshgudimetla
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 81c10dd into kubernetes:master Oct 14, 2018
k8s-ci-robot referenced this pull request Oct 15, 2018
@k8s-ci-robot
Merge pull request #69759 from bsalamat/automated-cherry-pick-of-#697…
8288d32 
…58-release-1.12

Fix a bug in node tree when all nodes in a zone are removed
@bsalamat bsalamat deleted the fix_node_tree branch October 15, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@ravisantoshgudimetla ravisantoshgudimetla

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing Test: timeout in deployment on gci-gke-serial
6 participants
@bsalamat @k8s-ci-robot @AishSundar @k82cn @fejta-bot @ravisantoshgudimetla