Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cluster Autoscaler version to 1.3.1 #66123

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Update Cluster Autoscaler version to 1.3.1 #66123

merged 1 commit into from
Aug 2, 2018

Conversation

aleksandra-malinowska
Copy link
Contributor

Cherry-pick of changes from #65857 and #66122. Not automated since we need the change to manifest file, but don't want to introduce beta image on release branch.

Cluster Autoscaler version updated to 1.3.1. Release notes: https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.3.1
Default value for expendable pod priority cutoff in GCP deployment of Cluster Autoscaler changed from 0 to -10.

action required: users deploying workloads with priority lower than 0 may want to use priority lower than -10 to avoid triggering scale-up.

/cc @MaciekPytel
/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Jul 12, 2018
@k8s-ci-robot k8s-ci-robot requested a review from MaciekPytel July 12, 2018 11:44
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 12, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 12, 2018
@aleksandra-malinowska
Copy link
Contributor Author

/cc @foxish

@k8s-ci-robot k8s-ci-robot requested a review from foxish July 12, 2018 11:46
@MaciekPytel
Copy link
Contributor

/retest

@MaciekPytel
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2018
@aleksandra-malinowska
Copy link
Contributor Author

/milestone v1.11

@k8s-ci-robot
Copy link
Contributor

@aleksandra-malinowska: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aleksandra-malinowska
Copy link
Contributor Author

/retest

@MaciekPytel
Copy link
Contributor

@foxish Can you approve this cherry-pick?

@MaciekPytel
Copy link
Contributor

/retest

1 similar comment
@aleksandra-malinowska
Copy link
Contributor Author

/retest

@foxish foxish added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 2, 2018
@foxish
Copy link
Contributor

foxish commented Aug 2, 2018

/test pull-kubernetes-e2e-gke

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 56ad764 into kubernetes:release-1.11 Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@foxish foxish Awaiting requested review from foxish

Assignees

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleksandra-malinowska @MaciekPytel @k8s-ci-robot @foxish @k8s-github-robot