Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler - not able to read from config file if configmap is not found #59386

Conversation

ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Feb 6, 2018

What this PR does / why we need it:
As of now, we are not able to read config file if configmap is not present. The only way to make it work is to enable legacy mode which should not be the case.
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785
Release note:

Scheduler should be able to read from config file if configmap is not present.

/cc @bsalamat @ironcladlou

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 6, 2018
@k82cn
Copy link
Member

k82cn commented Feb 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2018
@@ -214,7 +214,7 @@ func (o *Options) applyDeprecatedHealthzPortToConfig() {
// 3. --algorithm-provider to use a named algorithm provider.
func (o *Options) applyDeprecatedAlgorithmSourceOptionsToConfig() {
switch {
case o.useLegacyPolicyConfig:
case o.useLegacyPolicyConfig || (len(o.policyConfigFile) > 0 && o.policyConfigMapName == ""):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/o.policyConfigMapName == ""/len(o.policyConfigMapName) == 0/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsalamat - Shall I create another PR for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravisantoshgudimetla No, thers is no need to send another PR.
Thanks for checking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops :)

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59165, 59386). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f611b32 into kubernetes:master Feb 6, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

Thanks @k82cn for LGTM.. @bsalamat Shall I create another PR for the change you suggested or do you think this is good enough?

openshift-merge-robot added a commit to openshift/origin that referenced this pull request Feb 26, 2018
…fig-flag

Automatic merge from submit-queue.

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found

Scheduler is not able to read from config file if configmap is not found. 

Upstream PR: kubernetes/kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal  @sjenning
@ravisantoshgudimetla ravisantoshgudimetla deleted the fix-scheduler-config-file branch February 27, 2018 15:00
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
…eduler-config-flag

Automatic merge from submit-queue.

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found

Scheduler is not able to read from config file if configmap is not found.

Upstream PR: kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal  @sjenning

Origin-commit: a1c2561ddfcb6c8d54c0188317dfabcbd25eca62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants