-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 1] Remove docker dep in kubelet startup #54405
Conversation
func NewDockerClientFromConfig(config *ClientConfig) libdocker.Interface { | ||
if config != nil { | ||
if config.IsFakeClient { | ||
// Create fake docker client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels wrong ... (mixing code used during testing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a2b9db5
to
9bc478c
Compare
Update bazel
9bc478c
to
de1c305
Compare
Yuju is kind of overload ... ping @kubernetes/sig-node-pr-reviews for first round review, then will kindly ask @yujuhong for final pass. |
@resouer - this lgtm. /lgtm |
fyi @sjenning -- it would be good to track this work. |
/test pull-kubernetes-unit |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, resouer, shyamjvs Associated issue: 54090 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Remove dependency of docker during kubelet start up.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):Part 1 of #54090
Special notes for your reviewer:
Changes include:
ClientConfig
from kubelet to dockershimFakeDockerClient
thruClientConfig
to dockershim(TODO, the second part) Make dockershim tolerate when dockerd is down, otherwise it will still fail kubelet
Please note after this PR, kubelet will still fail if dockerd is down, this will be fixed in the subsequent PR by making dockershim tolerate dockerd failure (initializing docker client in a separate goroutine), and refactoring cgroup and log driver detection.
Release note: