GCE: Ignore notFound when deleting firewall #53450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-github-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, nicksardo Associated issue: 53411 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
This was referenced Oct 4, 2017
|
Automatic merge from submit-queue (batch tested with PRs 51754, 53261, 53450). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-ci-robot
added
release-note
wojtek-t
added
the
cherry-pick-approved
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 5, 2017
…450-upstream-release-1.7 Automatic merge from submit-queue. Automated cherry pick of #53450 Cherry pick of #53450 on release-1.7. #53450: Ignore notFound when deleting firewall **Release note**: ```release-note GCE: Fix issue deleting internal load balancers when the firewall resource may not exist. ```
|
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 9, 2017
…450-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #53450 Cherry pick of #53450 on release-1.8. #53450: Ignore notFound when deleting firewall **Release note**: ```release-note GCE: Fix issue deleting internal load balancers when the firewall resource may not exist. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ignores a not found error when deleting a firewall on line 220.
Which issue this PR fixes:
Fixes #53411
Special notes for your reviewer:
/assign @MrHohn
Release note: