Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Heapster version to 1.4.3 #53377

Merged

Conversation

loburm
Copy link
Contributor

@loburm loburm commented Oct 3, 2017

Bumped Heapster version to 1.4.3 - more details https://github.com/kubernetes/heapster/releases/tag/v1.4.3.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2017
@loburm
Copy link
Contributor Author

loburm commented Oct 3, 2017

/assign @piosz @wojtek-t

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 3, 2017
@piosz piosz added this to the v1.8 milestone Oct 3, 2017
@piosz
Copy link
Member

piosz commented Oct 3, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loburm, piosz

Associated issue requirement bypassed by: piosz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@loburm
Copy link
Contributor Author

loburm commented Oct 3, 2017

/assign @jpbetz

@piosz
Copy link
Member

piosz commented Oct 3, 2017

@jpbetz to give you more context: we didn't manage to release the stable version of Heapster 1.5 before Kubernetes 1.8, so reverting to the previous stable version.

@liggitt
Copy link
Member

liggitt commented Oct 5, 2017

@jpbetz to give you more context: we didn't manage to release the stable version of Heapster 1.5 before Kubernetes 1.8, so reverting to the previous stable version.

how risky is this change? there's a fair number of issues pending a 1.8.1 release... is this going to extend the time we need to soak before cutting a 1.8.x release?

@jpbetz
Copy link
Contributor

jpbetz commented Oct 5, 2017

@piosz Would you please summarize what happens when a k8s cluster running heapster-v1.5.0-beta.0 is downgraded to heapster-v1.4.3. Has this been tested? Are there any steps cluster operators would need to take?

@piosz
Copy link
Member

piosz commented Oct 5, 2017

@liggitt low risk change - Heapster 1.4.3 is well tested with Kubernetes 1.7.
@jpbetz no action required. Heapster is almost stateless (it remembers the latest value of metrics) and doesn't have any API, so nothing should happen in case of downgrade, except from a short downtime window (up to 2 minutes) for horizontal pod autoscaler, which basically happens during every Heapster restart.

@piosz
Copy link
Member

piosz commented Oct 9, 2017

@jpbetz ping

@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

We're about to cut release 1.8.1. We are minimizing the cherry picks we accept to keep the branch stable. If this is a critical fix, please let me know and I'll review, otherwise it will be cherry picked for 1.8.2. Thanks!

@piosz
Copy link
Member

piosz commented Oct 9, 2017

@jpbetz yes, please include this is 1.8.1

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Oct 9, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 9, 2017
@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

/approved

@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

Looks like the pull-kubernetes-e2e-kubeadm-gce test is not progressing due to kubernetes/test-infra#4912. Looking in how to mitigate this now.

@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

/test pull-kubernetes-e2e-kubeadm-gce

@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

/test pull-kubernetes-e2e-kubeadm-gce

1 similar comment
@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

/test pull-kubernetes-e2e-kubeadm-gce

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 9, 2017

@loburm: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kubeadm-gce 96d591f link /test pull-kubernetes-e2e-kubeadm-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jpbetz
Copy link
Contributor

jpbetz commented Oct 9, 2017

/test pull-kubernetes-e2e-gce-etcd3

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 3ca805d into kubernetes:release-1.8 Oct 10, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants