-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped Heapster version to 1.4.3 #53377
Bumped Heapster version to 1.4.3 #53377
Conversation
loburm
commented
Oct 3, 2017
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: loburm, piosz Associated issue requirement bypassed by: piosz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/assign @jpbetz |
@jpbetz to give you more context: we didn't manage to release the stable version of Heapster 1.5 before Kubernetes 1.8, so reverting to the previous stable version. |
how risky is this change? there's a fair number of issues pending a 1.8.1 release... is this going to extend the time we need to soak before cutting a 1.8.x release? |
@piosz Would you please summarize what happens when a k8s cluster running heapster-v1.5.0-beta.0 is downgraded to heapster-v1.4.3. Has this been tested? Are there any steps cluster operators would need to take? |
@liggitt low risk change - Heapster 1.4.3 is well tested with Kubernetes 1.7. |
@jpbetz ping |
We're about to cut release 1.8.1. We are minimizing the cherry picks we accept to keep the branch stable. If this is a critical fix, please let me know and I'll review, otherwise it will be cherry picked for 1.8.2. Thanks! |
@jpbetz yes, please include this is 1.8.1 |
/approved |
Looks like the |
/test pull-kubernetes-e2e-kubeadm-gce |
/test pull-kubernetes-e2e-kubeadm-gce |
1 similar comment
/test pull-kubernetes-e2e-kubeadm-gce |
@loburm: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-e2e-gce-etcd3 |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |