Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make using service account credentials from controllers optional #35970

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 1, 2016

Adds a flag to make the "SA per controller" behavior optional.


This change is Reviewable

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Nov 1, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit b4b66bfa8a1a5ddacdf03c535357a47f266f950f. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Nov 1, 2016
@liggitt
Copy link
Member

liggitt commented Nov 1, 2016

LGTM, did you want to update any of the bring-up scripts to use this (e.g. local-up-cluster?)

@deads2k
Copy link
Contributor Author

deads2k commented Nov 1, 2016

LGTM, did you want to update any of the bring-up scripts to use this (e.g. local-up-cluster?)

I don't think so. I'm hoping for a seamless transition at some point in 1.6

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2016
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 1, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 5384822748de6b1d11831025472a7b8973fae09e. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@deads2k
Copy link
Contributor Author

deads2k commented Nov 1, 2016

@k8s-bot node e2e test this: issue #35935

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2016
@deads2k deads2k added this to the v1.5 milestone Nov 3, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2016
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit e420d4b4c3fde135ae8777d9c69e2ef9c29f7ad9. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit e420d4b4c3fde135ae8777d9c69e2ef9c29f7ad9. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@liggitt
Copy link
Member

liggitt commented Nov 4, 2016

W1104 05:57:59.138] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:8963: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.139] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:8973: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.140] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10223: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.140] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10225: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.140] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10781: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)
W1104 05:57:59.141] vendor/k8s.io/client-go/pkg/apis/componentconfig/types.generated.go:10783: x.UseServiceAccountCredentials undefined (type *KubeControllerManagerConfiguration has no field or method UseServiceAccountCredentials)

@liggitt
Copy link
Member

liggitt commented Nov 4, 2016

@caesarxuchao does #35970 (comment) mean that things that change API types now need to happen in two pull requests, and wait in between for an updated client-go to be vendored in?

@deads2k
Copy link
Contributor Author

deads2k commented Nov 4, 2016

@caesarxuchao does #35970 (comment) mean that things that change API types now need to happen in two pull requests, and wait in between for an updated client-go to be vendored in?

Might just have been a failure on my part to regen codecs. The object is internal only, so no codecs should be needed. I'll give it try.

@deads2k
Copy link
Contributor Author

deads2k commented Nov 4, 2016

Might just have been a failure on my part to regen codecs. The object is internal only, so no codecs should be needed. I'll give it try.

Nope, that didn't do anything. @caesarxuchao are we just waiting for a sync to remove those files?

@caesarxuchao
Copy link
Member

caesarxuchao commented Nov 4, 2016

You can run hack/update-staging-client-go.sh to update the staging area, but that will pick up many other changes because the script hasn't been run for a week. You don't need to update the staging area if you don't need to update client-go right now. I'll enable the update/verify-staging-client-go.sh during the code freeze to keep the staging area up-to-date.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2016
@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f160318 into kubernetes:master Nov 5, 2016
@deads2k deads2k deleted the controller-15-enable branch February 1, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants