-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodefs becomes imagefs on GCI #33520
Conversation
…rrectly Signed-off-by: Vishnu kannan <vishnuk@google.com>
P2 since it needs to be cherry-picked into 1.4 branch soon for stabilizing GCI tests. |
Checked the new configuration with @dashpole's newly introduced out-of-inode test on gci image, and it works. LGTM |
@vishh is this something that needs to be in 1.4.1? |
@jessfraz Ideally yes. I will try to get the tests to pass tomorrow. |
Thanks!! On Wednesday, October 5, 2016, Vish Kannan notifications@github.com wrote:
|
@k8s-bot node e2e test this github issue #IGNORE |
@k8s-bot gke e2e test this github issue #IGNORE |
@jessfraz Tests are green. 🙏 ing for no flakes. |
Jenkins GKE smoke e2e failed for commit e7633d8. Full PR test history. The magic incantation to run this job again is |
i think the submit queue is blocked :( On Thu, Oct 6, 2016 at 2:40 PM, k8s-ci-robot notifications@github.com
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
opened cherrypick here: #34296 |
cherry-picked to 1.4 in #34296 so removing cherry-pick candidate |
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
Automatic merge from submit-queue Cadvisor root path configuration This solves #33444 and reverts PR #33520. This takes the root directory and passes it to cadvisor, which sets up the "nodefs" based on the provided path, rather than using "/" as before. This PR is pending on changes in cadvisor, and will not pass tests until those changes are merged, and cadvisor godeps are updated. ```release-note kubelet summary rootfs now refers to the filesystem that contains the Kubelet RootDirectory (var/lib/kubelet) instead of cadvisor's rootfs ( / ), since they may be different filesystems. ```
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
…ck-of-#33520-kubernetes#34251-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#33520 kubernetes#34251 origin release 1.4 Cherry pick of kubernetes#33520 kubernetes#34251 on release-1.4. kubernetes#33520: nodefs becomes imagefs on GCI since kubelet cannot identify kubernetes#34251: Fix nil pointer issue when getting metrics from volume
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
Kubelet cannot identify rootfs correctly
For #33444
Signed-off-by: Vishnu kannan vishnuk@google.com
This change is