[e2e node] gcloud is included even local #31597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
|
GCE e2e build/test passed for commit 53c1c0c. |
yujuhong
added
release-note-none
|
@resouer why do we need |
|
Because we changed to use gci by default for local development, and we need gcloud to get newest gci image. However, the logic should be in remote run, not local run. I'll fix it. |
|
@Random-Liu sounds good. Let's close this PR. |
|
@resouer Thanks a lot! Good catch~ :) |
resouer
changed the title
resouer
changed the title
resouer
changed the title
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 30, 2016
Automatic merge from submit-queue Node E2E: Move the image and host related logic to be remote run specific. This PR addresses #31597, and better fixes #31588. With this PR: 1) All remote logic is moved into remote mode. 2) All gci related logic is only called when `HOSTS` and `IMAGES` are not specified. 3) Run node e2e against other node e2e images will work again - `make test-e2e-node REMOET=true IMAGES=e2e-node-containervm-v20160321-image`. 4) List images will work again - `make test-e2e-node REMOTE=true LIST_IMAGES=true`. Mark 1.4, because #31588 is marked as 1.4. And this makes the node e2e work as is described in the [doc ](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/e2e-node-tests.md#run-tests-using-different-images). @yujuhong @vishh /cc @kubernetes/sig-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when running e2e node test locally, we still need
gcloudon PATH, though it does not need to start any instances in cloud.So I suggest add a node in doc at least, otherwise, people may feel confused (so I did).
cc @yujuhong
This change is