allow restricting subresource access #29988
Merged
+52
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/M
|
GCE e2e build/test passed for commit 1e7adaa. |
|
LGTM |
deads2k
added
lgtm
remind me about the cherry-pick process. Do I tag it here or in the new pull? |
|
set milestone and tag here |
deads2k
added
priority/important-soon
liggitt
added
release-note
|
I think if you want to pick to 1.3, needs 1.3 milestone, which is weird |
|
needs release note |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 1e7adaa. |
|
Automatic merge from submit-queue |
fabioy
added
the
cherry-pick-approved
|
Cherrypick approved. Thanks. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 11, 2016
Automatic merge from submit-queue allow restricting subresource access Backport of #29988 to properly secure access to subresources. @kubernetes/sig-auth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30001) <!-- Reviewable:end -->
|
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
Automatic merge from submit-queue allow restricting subresource access Backport of kubernetes#29988 to properly secure access to subresources. @kubernetes/sig-auth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30001) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like subresource resolution got lost in the port. Adding it back in as
"resource/subresource". That allows easy expression of rules and we can later allow something like"*/subresource"to handle cases like the hpa controller.@kubernetes/sig-auth
This change is