-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container-port flag is deprecated #25072
Container-port flag is deprecated #25072
Conversation
LGTM @smarterclayton @bgrant0607 WDYT? |
@adohe |
LGTM |
@@ -2,6 +2,7 @@ | |||
|
|||
- [v1.3.0-alpha.3](#v130-alpha3) | |||
- [Downloads](#downloads) | |||
- [v1.3.0-alpha.3](#v130-alpha3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this added?
Is the policy to add |
815359d
to
ba69f0f
Compare
Okay, it's worthy a release note as it changes the ux. cc/ @david-mcmahon |
Thanks, LGTM. Deprecations belong in the "action required" section of the release notes. I updated that label. |
GCE e2e build/test passed for commit ba69f0f. |
Refer #25039 for more detail. @Kargakis ptal. Also in this PR just mark this flag as deprecated, we should also remove the code in the future.