Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extensions/replicaset to federation-apiserver #24764

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Add extensions/replicaset to federation-apiserver #24764

merged 1 commit into from
Jul 19, 2016
+90 −7

Conversation

jianhuiz
Copy link
Contributor

@jianhuiz jianhuiz commented Apr 25, 2016 •
edited
Loading

Add extensions/replicaset for federated scheduler (#24038) as all k8s api objects were removed in #23959

Please review only the very last one commit.
#19313 #23653

@nikhiljindal @quinton-hoole, @deepak-vij, @XiaoningDing, @alfred-huangjian @mfanjie @huangyuqi @colhom

@k8s-bot
Copy link

k8s-bot commented Apr 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Apr 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Apr 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Apr 25, 2016
@jianhuiz jianhuiz changed the title Add extensions/replicaset to federated-apiserver [WIP ]Add extensions/replicaset to federated-apiserver Apr 25, 2016
@jianhuiz jianhuiz changed the title [WIP ]Add extensions/replicaset to federated-apiserver Add extensions/replicaset to federated-apiserver Apr 26, 2016
@krousey krousey assigned nikhiljindal and unassigned krousey Apr 26, 2016
@krousey
Copy link
Contributor

krousey commented Apr 26, 2016

@nikhiljindal PTAL

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 27, 2016
@nikhiljindal nikhiljindal mentioned this pull request May 5, 2016
Closed
20 tasks
@k8s-bot
Copy link

k8s-bot commented May 6, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@nikhiljindal nikhiljindal added this to the next-candidate milestone May 9, 2016
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 20, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 15, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2016
@jianhuiz jianhuiz changed the title Add extensions/replicaset to federated-apiserver Add extensions/replicaset to federation-apiserver Jul 11, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 12, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@ghost ghost self-assigned this Jul 12, 2016
@mfanjie
Copy link

mfanjie commented Jul 12, 2016

what's the plan of this PR's merge? the federation scheduler depends on this PR.

nikhiljindal
nikhiljindal reviewed Jul 19, 2016
View reviewed changes
federation/cmd/federation-apiserver/app/server_test.go
@@ -285,3 +289,28 @@ func testCoreResourceList(t *testing.T) {
assert.NotNil(t, found)
assert.True(t, found.Namespaced)
}
func testExtensionsResourceList(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line break above this function

nikhiljindal
nikhiljindal reviewed Jul 19, 2016
View reviewed changes
federation/cmd/federation-apiserver/app/server_test.go
@@ -23,13 +23,15 @@ import (
"encoding/json"
"fmt"
"io/ioutil"
fed_v1b1 "k8s.io/kubernetes/federation/apis/federation/v1beta1"
//"k8s.io/kubernetes/federation/cmd/federated-apiserver/app/options"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@nikhiljindal
Copy link
Contributor

@k8s-bot ok to test.

A few minor nits, mostly LGTM

@nikhiljindal nikhiljindal added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 19, 2016
@nikhiljindal nikhiljindal modified the milestones: v1.4, next-candidate Jul 19, 2016
@jianhuiz
Copy link
Contributor Author

comments fixed and rebased

@k8s-bot
Copy link

k8s-bot commented Jul 19, 2016

GCE e2e build/test passed for commit bf3e1a5.

@ghost ghost removed their assignment Jul 19, 2016
@nikhiljindal
Copy link
Contributor

LGTM, thanks!

Next, you will need to update the federation client set to include extensions group version.
Right now it only includes federation/v1beta1 and api/v1 groups.
You need to update hack/update-codegen for that.

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 19, 2016

GCE e2e build/test passed for commit bf3e1a5.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d34c3fa into kubernetes:master Jul 19, 2016
@jianhuiz jianhuiz mentioned this pull request Jul 20, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 29, 2016
Merge pull request #29241 from jianhuiz/federation-apiserver-extensio…
0693d47 
…ns-replicaset-client

Automatic merge from submit-queue

Generate federation apiserver extensions replicaset client

generate clientset for extensions/ReplicaSet of federation apiserver

@nikhiljindal @quinton-hoole, @deepak-vij
#24764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@jianhuiz @k8s-bot @krousey @mfanjie @nikhiljindal @k8s-github-robot @googlebot