Add pod status/ready/restartCount conformance test #24191
Conversation
k8s-github-robot
added
size/L
|
@Random-Liu @pwittrock |
| Describe("container runtime conformance blackbox test", func() { | ||
| Context("when start a container that exits success", func() { | ||
| var terminateContainers []ConformanceContainer | ||
| It("it should run with the expected status [Conformance]", func() { |
There was a problem hiding this comment.
nits: Remove "it" from all the It description.
|
Updated |
k8s-github-robot
added
the
needs-rebase
|
Will review soon. |
k8s-github-robot
removed
the
needs-rebase
|
@liangchenye can you look into the test failures |
|
@liangchenye Also, can you break this PR up into 2 pieces. The first piece should fix the flaky test failures? |
|
@liangchenye As @pwittrock suggested, it would be better to send a separate PR to fix #24937 first. :) |
|
split into anther PR #25121 About the test failure, it is a timeout issue: the container is expected to run 3 times, but it fails to accomplish that within 5 minutes. I update by expecting it to restart 1 time. ---- sorry, my fault in the previous commit, it is not timeout issue. The timeout is unpredictable. How about using 'for loop' instead of 'Eventually'? If we catch a timeout, we could report it as a timeout warning other than a Expect error brought by 'Eventually'. |
|
Also saw the timeout issue in privileged_test.go. |
k8s-github-robot
added
the
needs-rebase
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
k8s-github-robot
added
kind/api-change
| @@ -62,37 +65,42 @@ func (matcher *ConformanceContainerEqualMatcher) NegatedFailureMessage(actual in | |||
| return format.Message(actual, "not to equal", matcher.Expected) | |||
| } | |||
|
|
|||
| func (cc *ConformanceContainer) SetName(name string) { | |||
| cc.Container.Name = name + string(util.NewUUID()) | |||
There was a problem hiding this comment.
We should randomize the pod name, not the container name.
- We could have different pods with same container name.
- We could not have pods with the same pod name and namespace.
Signed-off-by: liang chenye <liangchenye@huawei.com>
Random-Liu
added
lgtm
|
GCE e2e build/test passed for commit 4ddb160. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 4ddb160. |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue Node E2E: Shorten consistently check timeout of runtime conformance test #24191 increased the node e2e running time by almost half an hour. It makes the test running time exceed 60 minutes timeout, which causes quite a few issues (See #25639). As a quite fix, we'll skip all the runtime conformance test. @liangchenye We should remove redundant test cases in #24191 such as #24191 (comment), and reduce the test running time as much as possible.
…-release-4.1 Bug 1775757: KubeAPI server doesn't accept large patch requests Origin-commit: 1a80a974c6c728dc14d9b96c1e2aea274d0b7d22
add more test cases to cover containers which will be terminated/running/failed/pending.
Signed-off-by: liang chenye liangchenye@huawei.com