Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update opentelemetry dependencies to the latest release." #125731

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Revert "Update opentelemetry dependencies to the latest release." #125731

merged 5 commits into from
Jun 26, 2024

Conversation

dashpole
Copy link
Contributor

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Revert due to #125575 (comment)

Related to #125688

Special notes for your reviewer:

The PR could not be automatically reverted, so i've manually downgraded all dependencies updated by the PR

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2024
@dashpole
Copy link
Contributor Author

@liggitt @dims @thockin @serathius

@k8s-ci-robot k8s-ci-robot requested review from aramase, ardaguclu and a team June 26, 2024 13:40
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 26, 2024
liggitt
liggitt reviewed Jun 26, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7fdef894a2512bd2e472f776eefb2bd218fa42d

@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@dashpole
Copy link
Contributor Author

dashpole commented Jun 26, 2024 •
edited
Loading

Seems like this PR still hit #125688 (test run link)

@dashpole
Copy link
Contributor Author

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Jun 26, 2024 •
edited
Loading

Seems like this PR still hit #125688 (test run link)

cc @wojtek-t @p0lyn0mial @serathius for visibility that even with the grpc change reverted, the TestWatchSemantics test is still flaking. Is there another revert in flight that would address that?

=== CONT  TestWatchSemantics/allowWatchBookmarks=true,_sendInitialEvents=true,_RV=unset
    watcher_tests.go:1493: 
        	Error Trace:	/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/storage/testing/watcher_tests.go:1493
        	            				/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/storage/testing/utils.go:166
        	            				/home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/storage/testing/watcher_tests.go:1485
        	Error:      	"20" is not greater than or equal to "8"
        	Test:       	TestWatchSemantics/allowWatchBookmarks=true,_sendInitialEvents=true,_RV=unset
    --- FAIL: TestWatchSemantics/allowWatchBookmarks=true,_sendInitialEvents=true,_RV=unset (0.24s)

@liggitt liggitt mentioned this pull request Jun 26, 2024
Closed
@wojtek-t
Copy link
Member

cc @wojtek-t @p0lyn0mial @serathius for visibility that even with the grpc change reverted, the TestWatchSemantics test is still flaking. Is there another revert in flight that would address that?

heh....
introduced in #125721 as an attempt to speed up tests there (to reduce the time and avoid test timeouts)
looking into the error there it's "dumb" - we're comparing strings instead of the actual integers...

@liggitt - let me try to open a PR to fix that, unless you want to revert it...

@liggitt
Copy link
Member

liggitt commented Jun 26, 2024

introduced in #125721 as an attempt to speed up tests there (to reduce the time and avoid test timeouts) looking into the error there it's "dumb" - we're comparing strings instead of the actual integers...

@liggitt - let me try to open a PR to fix that, unless you want to revert it...

I don't have time to chase it, feel free to revert or fixup

@wojtek-t
Copy link
Member

I don't have time to chase it, feel free to revert or fixup

Will open a fix in few minutes

@wojtek-t wojtek-t mentioned this pull request Jun 26, 2024
Merged
@k8s-ci-robot
Copy link
Contributor

@dashpole: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit e89a2bf link unknown /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wojtek-t
Copy link
Member

/retest

[flake being fixed in https://github.com//pull/125733 ]

@k8s-ci-robot k8s-ci-robot merged commit a4b8d0f into kubernetes:master Jun 26, 2024
22 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 26, 2024
@serathius
Copy link
Contributor

Confirmed it's an issue with upgrading google.golang.org/grpc

@dashpole dashpole deleted the revert_otel branch June 26, 2024 18:20
@serathius
Copy link
Contributor

serathius commented Jun 26, 2024 •
edited
Loading

Issue first appears on grpc v1.64.0. We could consider upgrading opentelemetry assuming we can stay on grpc v1.63.0.

@serathius
Copy link
Contributor

https://github.com/grpc/grpc-go/releases/tag/v1.64.0

metadata/metadata: Implement the fmt.Stringer interface for pretty printing MD (https://github.com/grpc/grpc-go/pull/7137)

@serathius
Copy link
Contributor

OMG they made String() non-deterministic

https://github.com/grpc/grpc-go/blob/98e5deebae600b6cd50d2f41bcb5155f8471d53f/metadata/metadata.go#L93-L106

This was referenced Jun 28, 2024
Merged
Merged
@cici37
Copy link
Contributor

cici37 commented Jul 9, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@aramase aramase Awaiting requested review from aramase

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aojea aojea Awaiting requested review from aojea

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG CLI
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@dashpole @liggitt @k8s-ci-robot @wojtek-t @serathius @cici37