Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha2 versioning for kubeadm configuration structs #750

Closed
liztio opened this issue Apr 12, 2018 · 4 comments
Closed

v1alpha2 versioning for kubeadm configuration structs #750

liztio opened this issue Apr 12, 2018 · 4 comments
Assignees
Labels
area/upgrades area/UX kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. kind/refactor lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@liztio
Copy link

liztio commented Apr 12, 2018

Presently, Kubeadm's config file is in alpha state, which means it can and and does change without notice. Because Kubeadm needs to work consistently with configuration written by many versions, it's important that this format doesn't change.

The current configuration file embeds TypeMeta, but this is never set. Even if it was, the alpha versions of some other structs we link to and embed mean we can't rely on this version being stable.

We want to get the Kubeadm MasterConfiguration version to at least v1beta1. This involves making sure all constituent structs are at least Beta status. We will also need to make sure the defaults and internal versions work with the Beta struct.

@liztio liztio added kind/enhancement area/upgrades priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/UX kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 12, 2018
@liztio
Copy link
Author

liztio commented Apr 12, 2018

/cc @timothysc

@timothysc
Copy link
Member

/assign @liztio

@timothysc timothysc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 26, 2018
@timothysc timothysc added this to the v1.11 milestone Apr 26, 2018
@timothysc
Copy link
Member

I would definitely model this after the component-config work, and a KEP is required.

This supersedes #117

@luxas luxas added kind/refactor lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels May 23, 2018
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/enhancement labels Jun 5, 2018
@luxas luxas changed the title Stable versioning for Kubeadm configuration structs. v1alpha2 versioning for kubeadm configuration structs Jun 12, 2018
@luxas
Copy link
Member

luxas commented Jun 12, 2018

The KEP https://github.com/kubernetes/community/blob/master/keps/sig-cluster-lifecycle/0008-20180504-kubeadm-config-beta.md is not finished for actually reaching the beta state, needs to get updated with more information. Also, a couple of changes have been made to the proposal since @liztio was writing this.

However, we merged the inital kep as a starting point, and will improve it over time.
Here is a list of the changes that have been made to improve the kubeadm API machinery usage and APIs generally:

I repurposed this issue to be targeted at releasing the v1alpha2 API version in time for kubeadm v1.11.
For beta, we need to

  • update the KEP to reflect the current state
  • improve the structure of our API types further (gdocs proposal)
  • decide whether to embed other components' ComponentConfig in our types or not

The v1alpha2 part here is done though, so I'm closing this issue, and opening a new one for v1beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/upgrades area/UX kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. kind/refactor lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

4 participants