-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-evaluate kubeadm-config download and dynamic defaults #2328
Comments
I'm still making up my mind around this topic, but what about rephrasing the second goal in
My assumption is that defaults should be applied only the first time a config is processed, during init or join, then all the other commands should rely on the values stored in the ConfigMap; Nb. due to the fact that we are not storing node-specific configuration, there could be some possible exception to this rule e.g for upgrades or renew-certs, but this requires further investigation |
would that work for |
My assumption is that defaults should be applied only the first time a config is processed, during init or join (or join control-plane) |
this PR reduced the unit test overhead by using static defaults (instead of dynamic) in most places: |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
here we saw a few problems with how kubeadm handles download of configuration from the cluster and then defaults it:
#2323
a couple of task here are:
kubeadm config images...
)The text was updated successfully, but these errors were encountered: