Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog note for breaking change in #371 #549

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

ehashman
Copy link
Member

What this PR does / why we need it:

Adds a note about breaking changes to the CHANGELOG for the 1.2.0 -> 1.3.0 upgrade.

The changelog does not currently warn about the deprecation of the --in-cluster flag, meaning that users on 1.2.0 releases and earlier who use --apiserver with the default --in-cluster=true flag have authentication break on upgrade.

Which issue(s) this PR fixes:

Fixes #543.

Other notes:

The behaviour from 1.2.0 can be emulated on upgrade by removing the --apiserver flag and setting the environment variable KUBERNETES_SERVICE_HOST to the API server value.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2018
@mxinden
Copy link
Contributor

mxinden commented Oct 3, 2018

Would you mind mentioning the fix via KUBERNETES_SERVICE_HOST in the changelog as well? Other than that this looks good to me, thanks for the follow up!

@andyxning
Copy link
Member

Please also add a notation about the deprecation PR #371

@ehashman
Copy link
Member Author

ehashman commented Oct 8, 2018

All feedback should be addressed.

@andyxning
Copy link
Member

@ehashman You should add a link to the #371 PR to make it a link instead of just a statement.

@ehashman
Copy link
Member Author

ehashman commented Oct 8, 2018

I figured it would auto-link but apparently not...

@andyxning
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, ehashman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2018
@andyxning
Copy link
Member

@ehashman Thanks for taking care of this!

@k8s-ci-robot k8s-ci-robot merged commit 442ceb0 into kubernetes:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KSM is unable to authenticate to cluster in 1.3.x+ releases
4 participants