-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog note for breaking change in #371 #549
Conversation
Would you mind mentioning the fix via |
Please also add a notation about the deprecation PR #371 |
All feedback should be addressed. |
@ehashman You should add a link to the |
I figured it would auto-link but apparently not... |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, ehashman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ehashman Thanks for taking care of this! |
What this PR does / why we need it:
Adds a note about breaking changes to the CHANGELOG for the 1.2.0 -> 1.3.0 upgrade.
The changelog does not currently warn about the deprecation of the
--in-cluster
flag, meaning that users on 1.2.0 releases and earlier who use--apiserver
with the default--in-cluster=true
flag have authentication break on upgrade.Which issue(s) this PR fixes:
Fixes #543.
Other notes:
The behaviour from 1.2.0 can be emulated on upgrade by removing the
--apiserver
flag and setting the environment variableKUBERNETES_SERVICE_HOST
to the API server value.