-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Labels not exported by KSM #2311
Comments
Whic metric does not have this label exactly ? |
None of the metrics have this label. When I port forward and open the /metrics page on local, I am not find this label anywhere on the page |
I got the issue. KSM was relabelling the metric name |
That is expected, the labels are only added to the /assign |
/triage accepted |
I too would like to see this particular feature added to kube-state-metrics. I'm trying to figure out how to get a metric time series which shows the versions of pods currently deployed. I figured I could do this by enforcing a version label being set on the pods, but without the ability to add my own labels to a metric, it becomes very difficult to do. |
Having this feature would be super helpful! We enforce an |
Sent a PR to solve this for pods - #2428. If the reviewers agree on the approach, can update it for all the resources. |
This feature request came up quite a few times already and was always rejected because we want to stick to a 1:1 mapping between Kubernetes objects and the metrics. Any processing on the data is something that should be done outside of kube-state-metrics. For instance you can already achieve what you are trying to do by aggregating the You also have to consider that if we were to add labels to all the metrics that would serious impacts on storage considering the sheer amount of data that would represent to essentially just store the same information over and over. Because of that, aggregation is preferred. |
What happened:
I am not able to add additional pod and deployment labels into the metrics exported by KSM. I have setup KSM via helm inside AWS EKS. Below is the change I made in the values file to add allow the additional label for pods
Here deplEnv is the label key. When I apply this change in the values file, I am seeing this extra args being passed in the deployment. When I port forward the KSM service I am not able to see this label in any of the metrics on the
/metrics
page.What you expected to happen:
Label with the key
deplEnv
visible in the pod and deployment metricsHow to reproduce it (as minimally and precisely as possible):
Apply the kube-state-metrics helm chart in AWS EKS(version 1.27) with the change mentioned above in the values file and then port forward the service
Anything else we need to know?:
Environment:
kubectl version
): 1.27The text was updated successfully, but these errors were encountered: