Skip to content

Specify required fixed MaxSurge and MaxUnavailable on MIGs #17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flopib
Copy link
Contributor

@flopib flopib commented Jul 3, 2025

When passing UpdatePolicy objects to GCP API, values for max_surge and max_unavailable are also expected.

According to the REST API documentation, those values default to the amount of zones in which the instance group operates. As kops uses zonal instance groups, that value must be set to 1.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @flopib. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from johngmyers July 3, 2025 11:49
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zetaab July 3, 2025 11:49
@hakman
Copy link
Member

hakman commented Jul 3, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2025
@hakman
Copy link
Member

hakman commented Jul 3, 2025

/cc @justinsb
/assign @justinsb

@k8s-ci-robot k8s-ci-robot requested a review from justinsb July 3, 2025 15:39
@flopib flopib force-pushed the fix-incomplete-gce-mig-updatepolicy branch from 72a7f6f to f42e52b Compare July 4, 2025 12:59
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flopib flopib force-pushed the fix-incomplete-gce-mig-updatepolicy branch from f42e52b to e0e51f2 Compare July 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants