Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow protokube to be a staged assets #4243

Open
chrislovecnm opened this issue Jan 9, 2018 · 5 comments
Open

Allow protokube to be a staged assets #4243

chrislovecnm opened this issue Jan 9, 2018 · 5 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@chrislovecnm
Copy link
Contributor

The asset API does not currently allow for protokube to be staged in a docker registry. This needs to be implemented.

  1. assets phase should d/l the tarball
  2. extract the tarball
  3. docker install the container locally
  4. push the container to the registry
@chrislovecnm chrislovecnm self-assigned this Jan 9, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2018
@chrislovecnm
Copy link
Contributor Author

/lifecycle frozen
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 9, 2018
@johngmyers
Copy link
Member

Protokube is a file asset, so is copied to the URL in the spec.assets.fileRepository. Why is there a requirement to turn it into an image pushed to the spec.assets.containerRegistry?

@chrislovecnm
Copy link
Contributor Author

@johngmyers this was opened two years ago. Things may have changed since then.

One reason, if I remember is that we cannot use a registry vulnerability scanner on protokube since it is a file asset.

@johngmyers
Copy link
Member

If it's for vulnerability scanning, then there is no requirement for the bootstrap script to pull it from the registry. A toolbox command would be a possible implementation. This is useful information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants