-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --controller
flag in up
& down
#868
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,6 +103,19 @@ test_k8s() { | |
sleep 2 # Sleep for k8s to catch up to deployment | ||
echo -e "\n${RED}kompose down -f $f ${NC}\n" | ||
./kompose down -f $f | ||
echo -e "\nTesting controller=daemonset key\n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should find an alternative way to write these integration tests (perhaps in a separate function? and only running the httpd.yaml test?) or even a separate file... It's a bit messy at the moment and we really need to refactor everything (using Do you mind opening an issue explaining that we should refactor our integration tests to use a Go file / make this better? As well as add a comment (and spacing above this line) with a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for adding issue as well. |
||
echo -e "\n${RED}kompose up -f $f --controller=daemonset ${NC}\n" | ||
./kompose up -f $f --controller=daemonset | ||
sleep 2 # Sleep for k8s to catch up to deployment | ||
echo -e "\n${RED}kompose down -f $f --controller=daemonset ${NC}\n" | ||
./kompose down -f $f --controller=daemonset | ||
echo -e "\nTesting controller=replicationcontroller key\n" | ||
echo -e "\n${RED}kompose up -f $f --controller=replicationcontroller ${NC}\n" | ||
./kompose up -f $f --controller=replicationcontroller | ||
sleep 2 # Sleep for k8s to catch up to deployment | ||
echo -e "\n${RED}kompose down -f $f --controller=replicationcontroller ${NC}\n" | ||
./kompose down -f $f --controller=replicationcontroller | ||
|
||
done | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too sure why this code is being added? Can you describe this at least within the commit description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will mention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdrage , updated commit message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update GitHub description too...