-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kompose.image-pull-secret invalid when use compose configs #1414
Conversation
Welcome @xingjianhui! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xingjianhui The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xingjianhui Can you add more description about the issue your PR is fixing? It's hard to understand based on your comment. May be some compose examples? |
If docker-compose set configs, Example source docker-compose.yaml
part of hello-deployment.yaml
|
/check-cla |
codes look good. Please check the CI result for fix related issues @xingjianhui |
@xingjianhui |
Hi, I found the problem so, and I found another problem when use |
/check-cla |
I fixed CI problem. |
@xingjianhui cla still failed |
/check-cla |
@xingjianhui still has ci issues |
It exit 0 when i exec |
@xingjianhui A local golangci script will be added soon |
@xingjianhui Thanks for your contribution |
kompose version: 1.23.0 (bc7d9f4)
compose version: 3.8
I found kompose.image-pull-secret will be invaild
when compose service has configs