Skip to content

Add warnings/error for image not specified  #80

Closed
@janetkuo

Description

Follow-up #79 (comment):

image is a required field in Kubernetes and without it the generated file can't be used.

From compose spec, v1 doesn't allow image being specified with build, and v2 allows you to do that but the image will be built from build.

We can print an error when we see build in the compose file. Would love to hear more thoughts.

Activity

surajssd

surajssd commented on Aug 6, 2016

@surajssd
Member

With Kubernetes:

  • image is must, until we come up with a build story

With OpenShift:

  • If build given we can create buildconfig
  • if image given well and good

cc: @kadel

ngtuna

ngtuna commented on Aug 10, 2016

@ngtuna
Contributor

Currently there is an unsupported key message if we see build in the compose file.
@surajssd : while working on the issue #92 of having image and build in the same compose service, you can also add a check for required fields like image

ngtuna

ngtuna commented on Oct 10, 2016

@ngtuna
Contributor

Closed via #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @ngtuna@janetkuo@surajssd

      Issue actions

        Add warnings/error for image not specified · Issue #80 · kubernetes/kompose