driver:local in prefixing volumes with current dir name

[kadel]

version: '2'
services:
  mariadb:
    image: 'bitnami/mariadb:latest'
    volumes:
      - 'mariadb-data:/bitnami/mariadb'
    environment:
      - MARIADB_USER=bn_wordpress
      - MARIADB_DATABASE=bitnami_wordpress
      - ALLOW_EMPTY_PASSWORD=yes
  wordpress:
    image: 'bitnami/wordpress:latest'
    ports:
      - '80:80'
      - '443:443'
    volumes:
      - 'wordpress-data:/bitnami/wordpress'
      - 'apache-data:/bitnami/apache'
      - 'php-data:/bitnami/php'
    depends_on:
      - mariadb
    environment:
      - MARIADB_HOST=mariadb
      - MARIADB_PORT=3306
      - WORDPRESS_DATABASE_USER=bn_wordpress
      - WORDPRESS_DATABASE_NAME=bitnami_wordpress
      - ALLOW_EMPTY_PASSWORD=yes
volumes:
  mariadb-data:
    driver: local
  wordpress-data:
    driver: local
  apache-data:
    driver: local
  php-data:
    driver: local

all PVC created from this file have names that are starting with name of current directory and _ as separator.

- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: kompose_apache-data
    name: kompose_apache-data
  spec:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 100Mi
  status: {}
- apiVersion: v1
  kind: PersistentVolumeClaim
  metadata:
    creationTimestamp: null
    labels:
      io.kompose.service: kompose_php-data
    name: kompose_php-data
  spec:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 100Mi
  status: {}
kind: List
metadata: {}

Problem is that Kubernetes doesn't allow _ in object names

From first quick look it seems to me that libcompose is doing that for some reason.

[surajnarwade]

@kadel , if we remove unsupported root level key volumes, then it works fine

[surajnarwade]

@kadel , https://github.com/docker/libcompose/blob/master/project/project.go#L335 line from libcompose is adding project directory name followed by _ in volume name, if root level volumes key is present. as volumes key is unsupported, it should be removed before kompose convert

[sebgoa]

@ngtuna maybe you can check this one out

All bitnami docker-compose examples use this type of local volume definitions, it would be great for kompose to support it.

[kadel]

@sebgoa @procrypt started looking into this

[procrypt]

@sebgoa I have started looking into it and almost finished will send the PR soon.

[sebgoa]

ok terrific, thanks

[dkarlovi]

@procrypt awesome, I'm getting hit by the same problem. <3

[procrypt]

@dkarlovi Can you share your docker-compose file. Since, I need more testing on this.

[dkarlovi]

@procrypt I'm creating an annonymized Compose file to send you and there I can't reproduce it?! But I'm trying it with my original Compose file and there it does add the prefix. Same kompose binary, different results, very weird. :(

I'll try to figure out what's the difference, in the meantime here's the Compose file I've used (but it's worthless to test with as it works for me too):

version: 2
services:
  web:
    image: registry.example.com/developers/docker:dkarlovi-web
    build:
      context: .
      dockerfile: ./.docker/nginx/Dockerfile
  app:
    image: registry.example.com/developers/docker:dkarlovi-app
    build:
      context: .
      dockerfile: ./.docker/php/Dockerfile
  db:
    image: registry.example.com/developers/docker:dkarlovi-db
    build:
      context: .
      dockerfile: ./.docker/mysql/Dockerfile
    volumes:
      - data:/var/lib/mysql
volumes:
  data: ~

[dkarlovi]

@procrypt managed to reproduce in #554 (comment)

[procrypt]

Hey @dkarlovi tired your docker-compose file I was able to deploy with kompose up but there were some issues with pulling images.

[dkarlovi]

@procrypt images are non-existent (original images are in a private registry anyway), you should use convert instead of up to verify created PVC names.

[procrypt]

@dkarlovi If you do kompose up using your file you should get an error because of the additional _ added to the object name and it should fail, anyways I have tried it with convert too and it works fine.