Skip to content

establish release process - protect master branch #192

Closed
@dustymabe

Description

@dustymabe

Hey hey!

I went to create the new rpm today for kompose 0.1.1 and see that the history is lost for the tag 0.1.1 from the master branch. According to the release page it was tagged from 534fa9b but that commit does not show up in the history for the master branch. I believe that means that the master branch was force pushed to in order to overwrite history.

Can we possibly do the following:

  • establish a methodical release process to follow for a release
  • protect the master branch from any force pushes ever (you can configure this in the settings in github so that it protects history from getting lost)
  • always do work through pull requests and require at least one maintainer +1 before doing a merge

Activity

ngtuna

ngtuna commented on Oct 7, 2016

@ngtuna
Contributor

Yes @dustymabe that was a mistake then I made a force push on 534fa9b.

establish a methodical release process to follow for a release

Yes. I believe @sebgoa is working on it.

protect the master branch from any force pushes ever (you can configure this in the settings in github so that it protects history from getting lost)

Done. I disabled force push on master and required to have one approved review prior to the PR is getting merged.

always do work through pull requests and require at least one maintainer +1 before doing a merge

We are having this procedure.

dustymabe

dustymabe commented on Oct 7, 2016

@dustymabe
ContributorAuthor

@ngtuna thanks! I guess once @sebgoa gets the docs for the release process published then we can close this issue.

for the record i think I'll wait for 0.1.2 to update the downstream rpm.

sebgoa

sebgoa commented on Nov 29, 2016

@sebgoa
Contributor

closing this for #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @sebgoa@ngtuna@dustymabe

      Issue actions

        establish release process - protect master branch · Issue #192 · kubernetes/kompose