Separate out annotation assignment logic

[alexkursell]

What this PR does / why we need it: In controller.go, annotation values were being applied to the created Locations in 4 separate places. This is long, pointless, and causes the annotations supported by the different kinds of Locations to drift apart as new annotations are added and people forget to add the assignment to one of the 4 places.

2 of the more recent examples of added annotations, HTTP2PushPreload and Satisfy only apply the annotations to 1 and 2, respectively, out of the 4.

Here are the annotations that this change will cause to be applied that previously weren't:

Catch-all location:

• HTTP2PushPreload
• XForwardedPrefix
• UsePortInRedirects
• Connection
• Logs
• DefaultBackend
• CustomHTTPErrors
• Satisfy

Default location

• HTTP2PushPreload
• Satisfy

New Location (not really sure what this one does that the one above it doesn't)

• HTTP2PushPreload

If any of these annotations actually shouldn't be applied to that type of location, please let me know so I can fix it.

[ElvinEfendi]

LGTM, I don't know why we would not wanna apply all annotations.

I'll let @aledbf review this as well

/approve

[aledbf]

@alexkursell @ElvinEfendi we had something like this in the past but that triggered some issues with the default backend when the service has no endpoints. That said, this is passing all the e2e test so I am not sure how to check this is ok or not.

[alexkursell]

@aledbf Do you know if there was a specific annotation causing the issue? The only change this should make to the controller behaviour is by adding the annotations I listed above.

[aledbf]

Merging. This cleanup makes sense. If we found issues we can review the change and narrow the scope of the changes

[aledbf]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, alexkursell, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi,aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment