-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Tests: Enable default backend access logging tests. #13787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Enable default backend access logging tests. #13787
Conversation
- Remove Skip calls from two E2E tests for default backend access logging - Tests were functionally complete but disabled with TODO comments - Enables validation of enable-access-log-for-default-backend configuration - Improves test coverage for default backend functionality This change enhances test coverage without adding new features, aligning with the project's maintenance mode priorities.
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
Hi @oyiz-michael. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind cleanup
/priority backlog
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, oyiz-michael The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.13 |
/cherry-pick release-1.12 |
@Gacko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #13788 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #13789 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko Thank you for the swift reviews, it's been pleasure contributing to this project. |
Enable default backend access logging tests
This change enhances test coverage without adding new features, aligning with the project's maintenance mode priorities.
What this PR does / why we need it:
This PR enables two E2E tests for default backend access logging that were previously skipped with TODO comments. The tests validate the
enable-access-log-for-default-backend
configuration option which controls whether nginx logs requests that hit the default backend (404 responses).Why this is needed:
enable-access-log-for-default-backend
feature is important for debugging and monitoringThe tests validate:
Types of changes
Which issue/s this PR fixes
This addresses a gap in test coverage rather than a specific reported issue. It enables existing tests that were disabled with TODO comments.
How Has This Been Tested?
Local Testing:
go build ./test/e2e/defaultbackend/...
passes without errorsgofmt -s -d
shows no formatting issuesTest Validation:
ginkgo.It()
assert.Contains()
andassert.NotContains()
Changes Made: