Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGINX: Remove unused substitutions module. #12449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elizabeth-dev
Copy link
Contributor

What this PR does / why we need it:

As part of the migration to NJS and sunsetting of Lua scripts, we can remove the substitutions module, since it appears unused.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

Part of #12383

How Has This Been Tested?

The codebase has been inspected in order to ensure the module isn't used anywhere, and the e2e test suite has been passed.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels Dec 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @elizabeth-dev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2024
Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 16e1364
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/675779f3e6837d0008ee5101

@elizabeth-dev elizabeth-dev force-pushed the feature/njs/remove-substitutions-module branch from 8fa542a to 5ba8a71 Compare December 7, 2024 22:30
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2024
@elizabeth-dev elizabeth-dev force-pushed the feature/njs/remove-substitutions-module branch 3 times, most recently from 5ba8a71 to 3f6510a Compare December 7, 2024 22:42
@strongjz strongjz added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 9, 2024
@strongjz
Copy link
Member

strongjz commented Dec 9, 2024

/kind cleanup
/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 9, 2024
@Gacko Gacko changed the title NGINX: Remove unused substitutions module NGINX: Remove unused substitutions module. Dec 9, 2024
@elizabeth-dev elizabeth-dev force-pushed the feature/njs/remove-substitutions-module branch from 3f6510a to 16e1364 Compare December 9, 2024 23:14
@rikatz
Copy link
Contributor

rikatz commented Dec 22, 2024

/lgtm
/cc @strongjz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elizabeth-dev, rikatz
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko
Copy link
Member

Gacko commented Dec 23, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2024
@rikatz
Copy link
Contributor

rikatz commented Dec 23, 2024

Reason for hold? James told me merging to main should be already happening again

@Gacko
Copy link
Member

Gacko commented Dec 23, 2024

No, it cannot. I haven't started building the images, yet.

@strongjz
Copy link
Member

I keep forgetting that nginx image isn't built on branches like the controller, it's built on main, so yea we can't merge this yet till we finish with 1.12 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants