Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nginx] Feature request: set client_body_buffer_size by annotation #826

Closed
Platzii opened this issue Jun 7, 2017 · 4 comments
Closed

[nginx] Feature request: set client_body_buffer_size by annotation #826

Platzii opened this issue Jun 7, 2017 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. nginx

Comments

@Platzii
Copy link

Platzii commented Jun 7, 2017

Hi guys

client_body_buffer_size can already be set in the global configuration but then it applies to all locations, which is great!
But it would be even better if this option could be set for individual ingresses (defined by annotations) so it is applies to specific location scopes.

This can already be done with some similar settings like ingress.kubernetes.io/proxy-body-size.

Kind regards
Simon

@aledbf aledbf added nginx enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 14, 2017
@diazjf
Copy link

diazjf commented Jul 25, 2017

client_body_buffer_size can be applied to http, server, location. The annotation can look as follows:

  1. ingress.kubernetes.io/proxy-body-size: <host>:<size>
  2. ingress.kubernetes.io/proxy-body-size: <host>:<location>:<size>
  3. It can also delimit by ; for multiple locations within one ingress file.

This will support most relevant cases.
@Platzii @aledbf Let me know your suggestions and I can pickup this task (Assign me if you can).

I appreciate your time.

@zjj2wry
Copy link

zjj2wry commented Aug 12, 2017

@aledbf @diazjf anyone process for this issue? if not, i can help for fix this. thanks

@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

@diazjf this should be just ingress.kubernetes.io/proxy-body-size: <size>. The host and location should come from the ingress

@diazjf
Copy link

diazjf commented Aug 20, 2017

@Platzii @aledbf PR started right here: #1186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. nginx
Projects
None yet
Development

No branches or pull requests

4 participants