Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading and configuring Jaeger as the opentracing backend #1808

Closed
jhorwit2 opened this issue Dec 7, 2017 · 3 comments · Fixed by #1916
Closed

Add support for loading and configuring Jaeger as the opentracing backend #1808

jhorwit2 opened this issue Dec 7, 2017 · 3 comments · Fixed by #1916
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jhorwit2
Copy link

jhorwit2 commented Dec 7, 2017

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/.):

What keywords did you search in NGINX Ingress controller issues before filing this one? (If you have found any duplicates, you should instead reply there.):

jaeger


Is this a BUG REPORT or FEATURE REQUEST? (choose one):

FEATURE

NGINX Ingress controller version:

latest

What happened:

Currently, there is only support for configuring and enabling Zipkin with opentracing. The only way to enable jaeger support is to customize the template to include the options found here

What you expected to happen:

I expect that jaeger should be easily enabled and configurable just like Zipkin.

@aledbf
Copy link
Member

aledbf commented Dec 7, 2017

@jhorwit2 the jaeger support was added before the latest release. We will include the configuration in the next version

@aledbf aledbf added enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 7, 2017
@andor44
Copy link

andor44 commented Dec 8, 2017

As a small correction, the custom template is not enough to get Jaeger support going, as it needs the custom Jaeger module, which is currently not compiled in nginx-ingress-controller.

@aledbf
Copy link
Member

aledbf commented Dec 8, 2017

@andor44 I know :)
Please keep in mind the latest version of the custom nginx image contains the 0.1.1 version of the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants