Update OpenTelemetry Module

[shugg]

Ingress-NGINX 1.10.0 has dropped support for OpenTracing and Zipkin, favoring OpenTelemetry instead. The OpenTelemetry module used by Ingress-NGINX is based on a commit from September 12, 2023, and has received updates since then.

Could you please update the module to a more recent version?

The commit I am interested in enhances the module by setting the span status to error when an HTTP request returns a 5xx status code, following the OpenTelemetry specification similar to the previously supported OpenTracing module.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[longwuyuan]

/assign @esigo

[bforchhammer]

For what it's worth, with the current helm chart version 4.11.0 I seem to end up with two variants of the otel_ngx_module.so file:

• one in /etc/nginx/modules/otel_ngx_module.so <-- this one is loaded by the generated nginx.conf
• another one in /modules_mount/etc/nginx/modules/otel/otel_ngx_module.so, which seems to be ignored?

My impression from looking around the code was that the modules_mount volume is intended as a mechanism to swap out/add extra modules, ie. maybe one could use that to change the bundled otel module version? I haven't been able to figure out how or whether that could work though...

[shugg]

@esigo do you have any plans to update the module, or are you considering other options?

The updated module includes a change required so that calculating error rate metrics for application performance monitoring. With Ingress-NGINX versions before 1.10.0 this was possible when using OpenTracing.

[dmehala]

Duplicates of #11629. I strongly suggest to read all comments.

TL;DR: A new release of the otel_ngx_module is required.

[shugg]

Thank you for updating the module. It’s included in release 4.12.1, and for my use case, feature parity with the OpenTracing-based instrumentation has been restored.