Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hostname to HealthCheckConfig #2231

Open
AngellusMortis opened this issue Aug 15, 2023 · 5 comments
Open

Add Hostname to HealthCheckConfig #2231

AngellusMortis opened this issue Aug 15, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@AngellusMortis
Copy link

AngellusMortis commented Aug 15, 2023

Reopen #1046

The docs say the request host header will be set if it is in the pod containers spec.

Request Host header | Host: backend-ip-address | if present in the serving Pod's spec: containers[].readinessProbe.httpGet.httpHeaders

The issue is that this creates a race condition when first creating an ingress if it is created before the pods are deployed (i.e. via Helm). This means if you are deploying an application with strict hostname checking (i.e. Django), your ingress/load balancers will never become healthly unless you delete the ingress and re-add it after the initial deploy.

So it would be nice to actually be able to configure the hostname for the healthcheck as defined in the healthchecks REST API reference

Something like:

apiVersion: cloud.google.com/v1
kind: BackendConfig
metadata:
  name: service-backend-config
spec:
  healthCheck:
    requestPath: /healthcheck/
    host: example.com
@ghost
Copy link

ghost commented Sep 14, 2023

I also need this. I don't always have control over what hostname deployment respond on. This is critical and I can do this in the console but not the BackendConfig. There's no technical reason why this couldn't be done.

@jasonwzm
Copy link

+1 for this as well.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@AngellusMortis
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@swetharepakula
Copy link
Member

/kind feature
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants