Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presubmit check to prevent accidental go directive bump #264

Closed
liggitt opened this issue Feb 28, 2024 · 1 comment · Fixed by #267
Closed

Add presubmit check to prevent accidental go directive bump #264

liggitt opened this issue Feb 28, 2024 · 1 comment · Fixed by #267
Assignees

Comments

@liggitt
Copy link
Member

liggitt commented Feb 28, 2024

Bumping the go directive in the go.mod files propagates to dependents virally, including kube-openapi.

Since this repo only releases from HEAD, we should be intentional when updating this directive since we may have to update on older kubernetes release branches.

Until golang/go#65573 is resolved and available, I'd suggest keeping the go directive in this repo no higher than the version of go reflected in the root go.mod file of the oldest supported kubernetes/kubernetes release branch

cc @thockin

@MadhavJivrajani
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants