Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional metrics guideline violations to metrics overhaul #655

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Add additional metrics guideline violations to metrics overhaul #655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf83d7a
Add additional metrics guideline violations to metrics overhaul
brancz Dec 15, 2018
91c5adc
Add instrumentation guidelines link to metrics overhaul
brancz Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ https://github.com/kubernetes/kubernetes/issues/68522

https://github.com/kubernetes/kubernetes/pull/63924

#### Prober metrics

Make proper metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the Kubernetes instrumentation guidelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Make proper metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the Kubernetes instrumentation guidelines.
Make prober metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the Kubernetes instrumentation guidelines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brancz -- could you link out to the instrumentation guidelines here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


### Risks and Mitigations

Risks include users upgrading Kubernetes, but not updating their usage of Kubernetes exposed metrics in alerting and dashboarding potentially causing incidents to go unnoticed.
Expand All @@ -108,4 +112,4 @@ All metrics exposed by components from kubernetes/kubernetes follow Prometheus b

## Implementation History

Multiple pull requests have already been opened, but not merged as of writing of this document.
Multiple pull requests have already been opened, but not merged as of writing of this document.