Skip to content

KEP-5471 Extended Toleration Operators for Threshold-Based Placement #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

KEP-5471 Extended Toleration Operators for Threshold-Based Placement #5473

wants to merge 13 commits into from

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Aug 11, 2025 •
edited
Loading

  • One-line PR description: Add numeric comparison operators (Lt, Gt) to Tolerations for SLA-based scheduling with threshold-based taint matching.
  • Other comments: cc @kubernetes/sig-scheduling-misc @kubernetes/sig-apps-misc

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 11, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Aug 11, 2025
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Aug 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dom4ha August 11, 2025 21:48
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Aug 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from macsko August 11, 2025 21:48
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 11, 2025
This was referenced Aug 9, 2025
Open
Open
jackfrancis
jackfrancis reviewed Aug 11, 2025
View reviewed changes
jackfrancis
jackfrancis reviewed Aug 11, 2025
View reviewed changes
macsko
macsko reviewed Aug 14, 2025
View reviewed changes
@helayoty helayoty force-pushed the helayoty/enable-sla-based-schedule branch from 2a36559 to c9e75ba Compare August 15, 2025 23:18
@helayoty helayoty moved this from Needs Triage to In Progress in SIG Scheduling Aug 15, 2025
@macsko
Copy link
Member

macsko commented Aug 22, 2025

/cc @dom4ha @sanposhiho

@helayoty helayoty requested a review from everpeace August 22, 2025 15:39
macsko
macsko reviewed Aug 27, 2025
View reviewed changes
macsko
macsko reviewed Aug 28, 2025
View reviewed changes
macsko
macsko reviewed Sep 2, 2025
View reviewed changes
keps/sig-scheduling/5471-enable-sla-based-scheduling/README.md

### Semantics

- To honor Kubernetes APIs that avoids floating-point numbers where possible due to precision and parsing issues, The new toleration operators will be introduced as integers (i.e.; 950 = 95.0%, 999 = 99.9%, 800 = 80.0%).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be well documented in the API to make sure the users won't misunderstand

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree and will be handled in the website/doc PR.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2025
@helayoty helayoty force-pushed the helayoty/enable-sla-based-schedule branch from a65244f to 2bdd819 Compare September 2, 2025 19:04
@helayoty helayoty requested a review from macsko September 8, 2025 16:37
macsko
macsko reviewed Sep 11, 2025
View reviewed changes
@helayoty helayoty force-pushed the helayoty/enable-sla-based-schedule branch from b3aff04 to f21031e Compare September 17, 2025 00:40
@helayoty helayoty requested a review from macsko September 17, 2025 00:40
sanposhiho
sanposhiho reviewed Sep 21, 2025
View reviewed changes
@helayoty helayoty requested a review from sanposhiho September 22, 2025 21:30
@helayoty helayoty force-pushed the helayoty/enable-sla-based-schedule branch from f977561 to 11d2a8e Compare September 29, 2025 20:57
macsko
macsko reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@macsko macsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Only nits from my side.

@helayoty helayoty requested a review from macsko October 3, 2025 16:13
helayoty added 13 commits October 7, 2025 12:20
@helayoty
Implement Extended Toleration Operators KEP
df942ce 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
Address feedback by remove Ge/Le and add DRA example
7e5ac73 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
Address PreferNoSchedule feedback
f814487 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
format toc
b2e3f99 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
Address feedback
a6b3719 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
Remove comments and address feedback
f0442a7 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
update TaintToleration and compareValue func to return error
3c07edf 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
addresss feedback
5d464cb 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
update feedback
e86f68e 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
update feedback
ca32660 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
update mitigations
064163b 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
feedback comments
2f80e5c 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty
update checklist
30995a2 
Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
@helayoty helayoty force-pushed the helayoty/enable-sla-based-schedule branch from 378046a to 30995a2 Compare October 7, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom4ha dom4ha Awaiting requested review from dom4ha

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@everpeace everpeace Awaiting requested review from everpeace

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@macsko macsko Awaiting requested review from macsko

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Review
SIG Scheduling
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@helayoty @macsko @k8s-ci-robot @everpeace @jackfrancis @SergeyKanzhelev @nojnhuh @sanposhiho