Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VolumeGroupSnapshot KEP for Beta #4734

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Update VolumeGroupSnapshot KEP for Beta #4734

merged 3 commits into from
Oct 10, 2024

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Jun 17, 2024 •
edited
Loading

  • One-line PR description:
    The PR updates VolumeGroupSnapshot KEP to target Beta in 1.32.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2024
@xing-yang xing-yang changed the title WIP: Update VolumeGroupSnapshot KEP for Beta Update VolumeGroupSnapshot KEP for Beta Sep 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@xing-yang
Copy link
Contributor Author

/assign @bswartz @msau42

@xing-yang xing-yang mentioned this pull request Sep 11, 2024
Closed
8 tasks
@xing-yang
Copy link
Contributor Author

/assign @jsafrane

johnbelamaric
johnbelamaric reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description of what particular failure mode you are describing the way to detect and mitigate? Is this something like "volume group snapshots fail to be created"?

@xing-yang
Copy link
Contributor Author

Can you add a description of what particular failure mode you are describing the way to detect and mitigate? Is this something like "volume group snapshots fail to be created"?

@johnbelamaric I added a short description of the failure mode. Please take a look. Thanks.

@xing-yang
Copy link
Contributor Author

@msau42 @jsafrane I updated the KEP based on our discussions. Please take a look. Thanks.

@johnbelamaric
Copy link
Member

thanks, PRR looks good

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@xing-yang
Copy link
Contributor Author

@jsafrane All your comments are resolved now. Please take another look. Thanks.

@xing-yang
Copy link
Contributor Author

@msau42 I addressed your comments. Please take another look. Thanks.

@jsafrane
Copy link
Member

I think it looks good enough for "implementable", we can iron out the API during API review and implementation.

@msau42
Copy link
Member

msau42 commented Oct 10, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit cec83d3 into kubernetes:master Oct 10, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@jsafrane jsafrane jsafrane left review comments

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@bswartz bswartz

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@xing-yang @johnbelamaric @k8s-ci-robot @jsafrane @msau42 @bswartz