Skip to content

KEP 3157 (watch-list): add a new beta criterion #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

KEP 3157 (watch-list): add a new beta criterion #4453

merged 1 commit into from
Jan 31, 2024

Conversation

p0lyn0mial
Copy link
Contributor

  • One-line PR description: Adds an additional beta criterion for the WatchList feature.
  • Other comments: N/A

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from apelisse January 29, 2024 12:17
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2024
@p0lyn0mial
Copy link
Contributor Author

/assign @deads2k
/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t January 29, 2024 12:18
@deads2k
Copy link
Contributor

deads2k commented Jan 31, 2024

As I understand it, this is necessary to prevent significant additional latency on this form of list in misconfigured clusters.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8eda4e into kubernetes:master Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 31, 2024
@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2024

LGTM

@jpbetz jpbetz mentioned this pull request Feb 21, 2024
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@fedebongio fedebongio Awaiting requested review from fedebongio

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
4 participants
@p0lyn0mial @deads2k @k8s-ci-robot @wojtek-t