PodOverhead to GA

[SergeyKanzhelev]

PodOverhead is in beta for a long time. Feedback collected: https://docs.google.com/document/d/1uZNJvR3IPDL--z6H5prgDuOAi22lhUYRXejnbaZHmSk/edit# The feature meets graduation requirement

KEP: #688

/sig node
/assign @egernst
/cc @tallclair
/cc @ehashman

@ehashman for PRR review. This is mostly back-filling. So should be straightforward. Lmk if I need to find somebody else

[ehashman]

Completed first pass for PRR.

[SergeyKanzhelev]

Completed first pass for PRR.

Thank you for review! I addressed all the feedback.

[sftim]

Before this graduates to GA, I want to check something. I don't think the docs have covered how to set a default pod overhead.

For example, if you have only a single container runtime and you want to account for the overhead of that runtime, can you do that? Ideally, you then also have a mechanism that lets you add a new RuntimeClass and leave everything where you don't specify a RuntimeClass still using the default runtime and its default resource overheads.

If we don't have that, it's fine. The Pod overhead feature can still graduate. However, I strongly encourage documenting this situation clearly so that if it can't be done, readers can confidently tell that it's not possible.

[ehashman]

/approve
for PRR

Holding off on LGTM due to issue with metadata in kep.yaml

[SergeyKanzhelev]

Before this graduates to GA, I want to check something. I don't think the docs have covered how to set a default pod overhead.

Impossible today. Part of the feedback from @tallclair as well:

“Vision for PodOverhead was always that it would be turned on by default eventually. The way I pictured doing so was by configuring a default RuntimeClass that would be auto-applied to pods that don't specify one. Alternatively we could just set a default PodOverhead instead. I don't think that needs to be a blocker for GA, but perhaps something to think about.”

Created: kubernetes/website#31580 to track it

[SergeyKanzhelev]

/label tide/merge-method-squash

[dchen1107]

/approve from SIG Node

[ehashman]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, ehashman, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS [ehashman]
• keps/sig-node/OWNERS [dchen1107]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment