Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP: New kubelet gRPC API with endpoint returning local pods information #4188

Open
2 of 6 tasks
kl52752 opened this issue Sep 6, 2023 · 25 comments
Open
2 of 6 tasks
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@kl52752
Copy link
Contributor

kl52752 commented Sep 6, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 6, 2023
@kl52752
Copy link
Contributor Author

kl52752 commented Sep 6, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2023
@kl52752 kl52752 changed the title KEP-4034: New kubelet gRPC API with endpoint returning local pods information KEP: New kubelet gRPC API with endpoint returning local pods information Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

@kl52752: The label(s) sig/arch cannot be applied, because the repository doesn't have them.

In response to this:

/sig arch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kl52752
Copy link
Contributor Author

kl52752 commented Sep 7, 2023

/sig architecture

@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Sep 7, 2023
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Sep 15, 2023

/stage alpha
/milestone v1.29
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 15, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.29

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.29 Sep 15, 2023
@AnaMMedina21
Copy link
Member

Hola @kl52752👋, v1.29 Enhancements team here.

I am just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2023..

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

The status of this enhancement is marked as Tracked for Enhancements Freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@AnaMMedina21
Copy link
Member

Hey @kl52752 👋, v1.29 Enhancements team here, checking in once more as we approach the v1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October 2023. The status of this enhancement is marked as Tracked for Enhancements Freeze. It looks like #4184 is still open but it seems to be small edits to close it out. Let me know if I missed anything. Thank you!

@kl52752
Copy link
Contributor Author

kl52752 commented Oct 6, 2023

hi @AnaMMedina21 The PR for KEP was merged, yesterday

@taniaduggal
Copy link

Hey there @kl52752 ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@taniaduggal
Copy link

Hey there @kl52752 !, The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@taniaduggal
Copy link

Hey @kl52752 , Could you please update me on the status of docs for this enhancement? Thank you!

@kl52752
Copy link
Contributor Author

kl52752 commented Oct 19, 2023

hi @taniaduggal I don't think I will finish the feature work for 1.29 so I will not add this to the documentation.

@npolshakova
Copy link

Hi @kl52752, 1.29 Enhancements team here- thanks for letting us know, I'll remove this KEP from the tracking board.
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Oct 20, 2023
@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2024
@aojea
Copy link
Member

aojea commented Apr 8, 2024

@kl52752 @wojtek-t if in addition to the conditions we expose the status.PodIPs we solve one scalability problem with networking component that need to watch for this information, can we add them in addition to the conditions?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 8, 2024
@SergeyKanzhelev
Copy link
Member

/remove-lifecycle rotten

As far as I know, activity on this one is on pause now. But it is still a desireable feature to have

@SergeyKanzhelev
Copy link
Member

Before re-starting this KEP, we need to reevaluate more feedback. Specifically this from @deads2k

#4184 (comment)

I re-found this while having a look at https://github.com/kubernetes/enhancements/pull/4615/files and noticing that it was also dealing with the power and limitations of the existing grpc kubelet endpoint. In particular, I noticed that

  1. there is more than one resource needed for read powers from the kubelet
  2. even with a single resource, partitioning between the clients is desired (authentication)
  3. the clients using the existing grpc extension are trying tunnel http over the grpc to be able to re-use the existing client and controller libraries. Even the APIs don't match exactly, the dynamic client and controller libraries still operate extremely well.
  4. versioning of APIs is important for adoption and to allow old and new extensions to coexist

As I recall, versioning was well handled by this design, but the trajectory of resource grpc endpoint could inform future kubelet serving extensions.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SergeyKanzhelev
Copy link
Member

/reopen
/remove-lifecycle rotten

I believe this is still desirable feature

@k8s-ci-robot k8s-ci-robot reopened this Jun 12, 2024
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

I believe this is still desirable feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 12, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2024
@SergeyKanzhelev
Copy link
Member

/remove-lifecycle stale

this is still a desirable API

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Removed from Milestone
Status: Triage
Development

No branches or pull requests

9 participants