-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate status.nodeInfo.kubeProxyVersion field #4004
Comments
/sig node |
/cc @thockin |
/milestone v1.28 |
What the staus on this? Alpha in 29? |
Yes, we'll be in Alpha at v1.29 |
/milestone v1.29 |
Hello @HirazawaUi 👋, 1.29 Enhancements team here! Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
The status of this enhancement is marked as |
Hi @HirazawaUi 👋, v1.29 Communication Release Team. I would like to check any plan about publication blogs related new features, removals, and deprecations for this release. You need to open a PR placeholder in the website repository. |
Ok, I've opened a PR placeholder in the website repository, thanks for the tip! |
Hi @HirazawaUi 👋, v1.29 Docs Shadow here |
I have opened a placeholder PR at k/website. |
Hello @sanposhiho 👋, v1.29 Enhancements team here. Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 Here's where this enhancement currently stands:
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. With all this, the status of this KEP is As always, we are here to help if any questions come up. Thanks! |
Hello @sanposhiho👋, 1.29 Enhancements team here. With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. Let me know if there are additional test PRs we should track. Thanks! |
@HirazawaUi @sanposhiho Hi, 1.29 Comms Team again! You indicated you were planning to write a blog post for this feature. A reminder that today (November 14, 2023) is the deadline for opening a Draft blog PR. We noticed Docs PRs, but no blog PR. Would you please update us about your plans? |
This is just a simple mini-KEP, I think there is no need for blog PR. |
/remove-label lead-opted-in |
/stage beta |
Hello @HirazawaUi 👋, v1.31 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, everything is taken care of in #4625. Please make sure that it is merged in time before the enhancements freeze. The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
With #4625 merged, we can mark this KEP as tracked for enhancements freeze! 🎉 |
Hello again @HirazawaUi @danwinship (hope you both read this one after the other comments so that "again" makes sense 😄 ) 👋 from the v1.31 Communications Team! To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines. Note: In your placeholder PR, use |
Reminder of the 3rd of July deadline! |
@mbianchidev Thanks for the heads up, but I see @a-mccarthy has already added a PR for the blog, I'll ask if my assistance is needed to complete it |
@HirazawaUi just to clarify, we are planning to include this in the Deprecations and Removal blog for 1.31. However, if you feel that this change requires a separate, full blog article to help users understand the changes, please open placeholder PR. perfectly ok, if the full blog post is not needed. thanks! :) |
Hey again @HirazawaUi 👋 v1.31 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024. Here's where this enhancement currently stands:
List of associated PRs: If you anticipate missing code freeze, you can file an exception request in advance. This KEP is marked as |
I missed that this was wanting to promote to beta in 1.31 ... because this is clearing population of a stable API field, the minimum period from announcement (in 1.29) is 1 year, so 1.33 is the earliest this can default to clearing. I'll open a revert of the enablement for master / 1.31 |
I'm not sure with @liggitt point if this KEP will be worked on 1.32. Please let me know if you want reviews for the KEP from sig-node in 1.32. |
I think it would stay as-is for 1.32 and default-enable in 1.33 |
…n` field The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not. The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status. There is no added value in checking this field in the upgrade tests due to the reasons from above. Ref kubernetes/enhancements#4004
…n` field The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not. The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status. There is no added value in checking this field in the upgrade tests due to the reasons from above. Ref kubernetes/enhancements#4004
…n` field The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not. The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status. There is no added value in checking this field in the upgrade tests due to the reasons from above. Ref kubernetes/enhancements#4004
…n` field The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not. The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status. There is no added value in checking this field in the upgrade tests due to the reasons from above. Ref kubernetes/enhancements#4004
Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32. /remove-label lead-opted-in |
…n` field The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not. The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status. There is no added value in checking this field in the upgrade tests due to the reasons from above. Ref kubernetes/enhancements#4004
* Allow instantiating v1.31 Kubernetes clients * Update `README.md` and `docs/usage/supported_k8s_versions.md` for K8s 1.31 * Maintain added feature gates ``` ./hack/compare-k8s-feature-gates.sh 1.30 1.31 Feature gates added in 1.31 compared to 1.30: AllowDNSOnlyNodeCSR AllowInsecureKubeletCertificateSigningRequests AnonymousAuthConfigurableEndpoints AuthorizeNodeWithSelectors AuthorizeWithSelectors ConcurrentWatchObjectDecode CoordinatedLeaderElection DRAControlPlaneController DisableAllocatorDualWrite ImageVolume ReloadKubeletServerCertificateFile ResilientWatchCacheInitialization ResourceHealthStatus SupplementalGroupsPolicy WatchCacheInitializationPostStartHook ``` * Maintain removed feature gates ``` ./hack/compare-k8s-feature-gates.sh 1.30 1.31 Feature gates removed in 1.31 compared to 1.30: APIPriorityAndFairness CSIMigrationRBD CSINodeExpandSecret ConsistentHTTPGetHandlers CustomResourceValidationExpressions DefaultHostNetworkHostPortsInPodTemplates InTreePluginAWSUnregister InTreePluginAzureDiskUnregister InTreePluginAzureFileUnregister InTreePluginGCEUnregister InTreePluginOpenStackUnregister InTreePluginRBDUnregister InTreePluginvSphereUnregister JobReadyPods ReadWriteOncePod ServiceNodePortStaticSubrange SkipReadOnlyValidationGCE ``` * Maintain locked to default feature gates ``` ./hack/compare-k8s-feature-gates.sh 1.30 1.31 Feature gates locked to default in 1.31 compared to 1.30: AppArmor Default: true AppArmorFields Default: true DevicePluginCDIDevices Default: true DisableCloudProviders Default: true DisableKubeletCloudCredentialProviders Default: true ElasticIndexedJob Default: true JobPodFailurePolicy Default: true KubeProxyDrainingTerminatingNodes Default: true LogarithmicScaleDown Default: true PDBUnhealthyPodEvictionPolicy Default: true PersistentVolumeLastPhaseTransitionTime Default: true PodDisruptionConditions Default: true StatefulSetStartOrdinal Default: true ``` * Maintain admission plugins ``` ./hack/compare-k8s-admission-plugins.sh 1.30 1.31 Admission plugins added in 1.31 compared to 1.30: Admission plugins removed in 1.31 compared to 1.30: PersistentVolumeLabel ``` * Maintain API groups ``` ./hack/compare-k8s-api-groups.sh 1.30 1.31 Kubernetes API group versions added in 1.31 compared to 1.30: coordination.k8s.io/v1alpha1 resource.k8s.io/v1alpha3 Kubernetes API GVRs added in 1.31 compared to 1.30: coordination.k8s.io/v1alpha1/leasecandidates networking.k8s.io/v1beta1/ipaddresses networking.k8s.io/v1beta1/servicecidrs resource.k8s.io/v1alpha3/deviceclasses resource.k8s.io/v1alpha3/podschedulingcontexts resource.k8s.io/v1alpha3/resourceclaims resource.k8s.io/v1alpha3/resourceclaimtemplates resource.k8s.io/v1alpha3/resourceslices storage.k8s.io/v1beta1/volumeattributesclasses Kubernetes API group versions removed in 1.31 compared to 1.30: resource.k8s.io/v1alpha2 Kubernetes API GVRs removed in 1.31 compared to 1.30: resource.k8s.io/v1alpha2/podschedulingcontexts resource.k8s.io/v1alpha2/resourceclaimparameters resource.k8s.io/v1alpha2/resourceclaims resource.k8s.io/v1alpha2/resourceclaimtemplates resource.k8s.io/v1alpha2/resourceclasses resource.k8s.io/v1alpha2/resourceclassparameters resource.k8s.io/v1alpha2/resourceslices ``` * Maintain kube-controller-manager controllers ``` ./hack/compute-k8s-controllers.sh 1.30 1.31 kube-controller-manager controllers added in 1.31 compared to 1.30: Added Controllers for API Group [networking/v1beta1]: service-cidr-controller Added Controllers for API Group [resource/v1alpha3]: resourceclaim-controller kube-controller-manager controllers removed in 1.31 compared to 1.30: Removed Controllers for API Group [networking/v1alpha1]: service-cidr-controller Removed Controllers for API Group [resource/v1alpha2]: resourceclaim-controller ``` * [no-op] Maintain copies of the DaemonSet controller's scheduling logic * Add K8s 1.31 to the local CloudProfile * tests: Don't check for Node's `.status field.nodeInfo.kubeProxyVersion` field The `.status field.nodeInfo.kubeProxyVersion` is a lie since its initial introduction. The field is set by kubelet which cannot know the kube-proxy version or whether kube-proxy is running at all or not. The `DisableNodeKubeProxyVersion` feature gate is enabled by default since K8s 1.31. The field is set to empty string in the Node status. There is no added value in checking this field in the upgrade tests due to the reasons from above. Ref kubernetes/enhancements#4004 * Add version constraints for K8s 1.31 * maintenance controller: Set `.spec.kubernetes.kubeAPIServer.oidcConfig.clientAuthentication=nil` when doing forceful update to K8s 1.31+ * maintenance controller: Move `kubernetes.kubelet.systemReserved` to `kubernetes.kubelet.kubeReserved` when doing forceful update to K8s 1.31+ * Nit: Use the KubeProxyEnabled helper func instead of duplicating the same logic * Update the e2e tests section in `docs/development/new-kubernetes-version.md` * Update provider extensions instructions in `docs/development/new-kubernetes-version.md` * Remove unnecessary logic for the `KubeletCgroupDriverFromCRI` feature gate Only the feature gate enablement is not enough the new auto-detection flow to be used. The feature depends on a new CRI API that will be present only in containerd 2.0+. Additionally, even if cgroup driver is specified and the new flow auto-detects another one from the CRI, it will ignore the specified cgroup driver and will use the auto-detected one. * Default kubelet's and containerd's cgroup driver to `systemd` for K8s 1.31+ * Update the local Garden Kubernetes version to 1.31 * Nit: Do not log admission is being deployed on make gardener-extensions-down * Order API groups alphabetically
Enhancement Description
status.nodeInfo.kubeProxyVersion
field of v1.Nodek/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s): KEP-4004: promote stage to beta #4625k/k
) update PR(s): promote DisableNodeKubeProxyVersion feature gate to beta kubernetes#123845k/website
) update(s): Document promote DisableNodeKubeProxyVersion feature gate to beta website#46935Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: