Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline KEP + PRR process for non-API changes #3399

Open
eddiezane opened this issue Jun 16, 2022 · 19 comments
Open

Streamline KEP + PRR process for non-API changes #3399

eddiezane opened this issue Jun 16, 2022 · 19 comments
Assignees
Labels
area/enhancements Issues or PRs related to the Enhancements subproject lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@eddiezane
Copy link
Member

The KEP template has grown to a point where a majority of the sections are primarily focused on API server enhancements and are less relevant to others. This is a pretty negative experience for myself as a maintainer and certainly even more confusing for folks that are new to the project.

Enhancements to the Kubernetes project entail more than serverside components. I think that the KEP template should be concise and limited to sections that are actually required/relevant to the proposed change.

One option we could consider is moving the PRR section to its own location as a supplement with clear criteria when it is necessary. Another is how we can tie in scopes.

I want to understand how we can streamline the process for features that don't interact with the API. For example, we plan to eventually add colors to the output of kubectl. We want to do a KEP as a design doc for collaboration but the process seems heavy handed for a change like that.

Other examples:

cc @kubernetes/production-readiness @kubernetes/enhancements

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 16, 2022
@mrbobbytables
Copy link
Member

/sig architecture
/area enhancements

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/enhancements Issues or PRs related to the Enhancements subproject and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 16, 2022
@thockin
Copy link
Member

thockin commented Jun 22, 2022

PRR is there to force people to think about the questions, not because there's always something to say.

I ACK that policy KEPs don't need it and should be able to delete or "N/A" it (but should they be able to bypass it?)

Or maybe we want a SMALL number of templates, e.g. README-tech.md vs README-nontech.md ?

@thockin thockin self-assigned this Jun 22, 2022
@mrbobbytables
Copy link
Member

We've tossed around multiple templates (+versioning them) etc in the past with general support. Part of the original goal for keptctl was to provide scaffolding for creating/updating KEPs based on what they're impacting. That largely didn't get driven forward due to lack of bandwidth / community consensus =/

I'd LOVE to overhaul and streamline the KEP process, its just everyone that knows the ins and outs has really been blocked on time.

@thockin
Copy link
Member

thockin commented Jun 22, 2022 via email

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 23, 2022

I've been working on a KEP template for process changes/non-technical changes but I think grouping those in this convo with more feature oriented KEPs is a bit misplaced. For now we don't actually have many process KEPs so it's not a terribly blocking issue for them to just n/a those sections and work is underway to have a better path for that.

Focusing more on technical KEPS and PRR: I'm hesitant to let authors just unilaterally opt-out across the board for actual features. As @thockin noted above, it's there to indicate to authors important things to think about and consider. N/A-ing (with an explanation of why it's n/a) feels like the safer option, rather than letting authors just pick a KEP template that doesn't include it from the start. I've put an agenda item on the Enhancements meeting for July 7th to discuss both.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 21, 2022
@eddiezane eddiezane removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 24, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2023
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2023
@thockin
Copy link
Member

thockin commented Apr 28, 2023

I don't want this to die off, but it seems that nobody is paying it attention. It doesn't seem super complex, and I almost let it nerd-snipe me, but I have other things to do this afternoon. I'll un-stale it once more, but maybe only one.

@jpbetz FYI

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Apr 28, 2023

@kikisdeliveryservice any thoughts on how to progress/reboot this? I'd like to contribute.

@jpbetz
Copy link
Contributor

jpbetz commented Apr 28, 2023

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Jan 19, 2024

/remove-lifecycle stale

I'm going to circle back on this.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Apr 23, 2024

I have a process kep template that I've been working on. I'll pull it back out and try to get a draft up to get conversation on this going again.

@thockin
Copy link
Member

thockin commented Apr 23, 2024

Awesome. This is perpetually on my list of "stuff to think about for this cycle".

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2024
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/enhancements Issues or PRs related to the Enhancements subproject lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Development

No branches or pull requests

9 participants