Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Api Object Templates #3

Closed
4 of 19 tasks
pwittrock opened this issue May 3, 2016 · 0 comments
Closed
4 of 19 tasks

Support Api Object Templates #3

pwittrock opened this issue May 3, 2016 · 0 comments

Comments

@pwittrock
Copy link
Member

pwittrock commented May 3, 2016

Thanks for wanting to add a feature to Kubernetes! You will be responsible for guiding
your feature through completion, and asking the right people for approvals.

Large features typically go through three stages: Alpha, Beta, and Stable
Each stage requires various approvals from various teams.

You can use the checkboxes below to
track your progress. You can delete the text above once you have read it. Please keep the checklist.

  • Before Alpha
    • Design Approval
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs
        • cc @kubernetes/docs on docs PR
        • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
        • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
      • Update release notes
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Before Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@pwittrock pwittrock added this to the v1.3 milestone May 6, 2016
pwittrock added a commit to pwittrock/kubernetes that referenced this issue May 16, 2016
pwittrock added a commit to pwittrock/kubernetes that referenced this issue May 16, 2016
- Add etcd storage for Template object
- Add stragegy for Template object
- Register Template Api types in the extensions api
- Register Template Api CRUD and Process endpoints in the master

Feature Issue: kubernetes/enhancements#3
pwittrock added a commit to pwittrock/kubernetes that referenced this issue May 17, 2016
Feature Issue: kubernetes/enhancements#3

- Add Template types to extensions/types.go and extensions/v1beta1/types.go
- Add etcd storage for Template object
- Add stragegy for Template object
- Register Template Api types in the extensions api
- Register Template Api CRUD and Process endpoints in the master
- Add generated client expansions
- Add kubectl 'get' and 'describe' support for Template Api objects
pwittrock added a commit to pwittrock/kubernetes that referenced this issue May 17, 2016
@pwittrock pwittrock removed this from the v1.3 milestone Jun 17, 2016
k8s-ci-robot pushed a commit that referenced this issue Jan 14, 2019
Remove blocks for updates to securitycontext + other stylistic changes
ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
enhancements/template: Drop 'enhancement(s)-' prefix
ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
…/kargs-day-1

Add Crawford into reviewers and approvers list
k8s-ci-robot pushed a commit that referenced this issue May 8, 2020
Added multi-node test scenarios
k8s-ci-robot pushed a commit that referenced this issue Feb 9, 2021
k8s-ci-robot pushed a commit that referenced this issue May 13, 2021
Ensure Implementation stategy captured in the KEP matches latest implementation
astoycos pushed a commit to astoycos/enhancements-1 that referenced this issue Sep 27, 2021
Add detail about future work and alternative approaches
k8s-ci-robot pushed a commit that referenced this issue Jun 17, 2022
chore: rename to `key_id` and use bytes for metadata
howardjohn pushed a commit to howardjohn/enhancements that referenced this issue Oct 21, 2022
Add templates for promoting features
justinsb pushed a commit to justinsb/features that referenced this issue Jan 26, 2023
* More clearly delineate specification vs kubectl details

* Move design details of spec to Design Details section
k8s-ci-robot pushed a commit that referenced this issue Feb 9, 2023
…ategy (#3661)

* Initial KEP for improving pruning in kubectl apply

* Add design details

Co-authored-by: Katrina Verey <katrina.verey@shopify.com>

* Add another open question

* Links, clarifications, ownerRef and GKNN explanations

* Follow-on to initial feedback, address some unresolved blocks

* Fix lint errors

* Add more detail about reference implementation (#2)

* Apply prune jan25 (#3)

* More clearly delineate specification vs kubectl details

* Move design details of spec to Design Details section

* Updates from synchronous conversation

* Remove leftover paragraph (#5)

Not an alternative rejected any more, given applyset.k8s.io/inventory

* Justin has always been coauthor

* KEP-3659: production readiness etc (#4)

Fill in the testing/ PRR sections.

* Fix test failures

* Prune: document confused deputy attack and mitigations

Likely pushes us to GKNN-derived IDs.

* Constrain applyset id

We just choose the constrained applyset id to prevent "applyset ID
impersonation".

* Update KEP and PRR metadata

* Enhance testing description

* ID vs name fixes

* Fixes from soltysh's review

---------

Co-authored-by: Justin Santa Barbara <justinsb@google.com>
k8s-ci-robot pushed a commit that referenced this issue Jun 13, 2023
shaneutt pushed a commit to shaneutt/enhancements that referenced this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant